On 16 November 2017 at 19:14, Michael Paquier wrote:
> On Thu, Nov 16, 2017 at 2:23 PM, David Rowley
> wrote:
>> I do get some warnings:
>>
>> (ClCompile target) ->
>> src/test/modules/test_session_hooks/test_session_hooks.c(112):
On Thu, Nov 16, 2017 at 2:23 PM, David Rowley
wrote:
> I do get some warnings:
>
> (ClCompile target) ->
> src/test/modules/test_session_hooks/test_session_hooks.c(112): warning
> C4113: 'void (__cdecl *)()' differs in parameter lists from
>
On Wed, Nov 15, 2017 at 5:22 PM, Tom Lane wrote:
> Thoughts?
Sure, having a win32_port.h as a sub-include of port.h seems fine.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
I wrote:
> Robert Haas writes:
>> On Wed, Nov 15, 2017 at 4:32 PM, Tom Lane wrote:
>>> How do you feel about "win32_more.h"?
>> Seems morally equivalent to what you had before. I think what I would
>> be looking for is a filename that somehow conveys
On Wed, Nov 15, 2017 at 4:32 PM, Tom Lane wrote:
>>> I have no objection to trying to clean things up in that area, but I
>>> request a less-lame filename than win32_2.h
>
>> Sure, if you have a suggestion.
>
> How do you feel about "win32_more.h"?
Seems morally equivalent to
I wrote:
> Robert Haas writes:
>> On Wed, Nov 15, 2017 at 10:51 AM, Tom Lane wrote:
>>> 1. Move what's currently in src/include/port/win32.h (a/k/a
>>> pg_config_os.h) to a new file, say src/include/port/win32_2.h.
>> I have no objection to trying to
Robert Haas writes:
> On Wed, Nov 15, 2017 at 10:51 AM, Tom Lane wrote:
>> 1. Move what's currently in src/include/port/win32.h (a/k/a
>> pg_config_os.h) to a new file, say src/include/port/win32_2.h.
> I have no objection to trying to clean things up