On Tue, 2 Sep 2025 14:00:52 -0400
Tom Lane wrote:
> Jim Jones writes:
> > LGTM; I'll mark the CF entry as Ready for Committer.
>
> Pushed with some trivial cosmetic adjustments, including the
> perhaps-not-so-trivial fix of removing the comment you falsified.
Thank you for committing the patch
Jim Jones writes:
> LGTM; I'll mark the CF entry as Ready for Committer.
Pushed with some trivial cosmetic adjustments, including the
perhaps-not-so-trivial fix of removing the comment you falsified.
I was concerned about Rahila's upthread worry about the performance
of this approach, but in som
On 26.08.25 04:55, Yugo Nagata wrote:
> Thank you for taking a look. That makes sense, so I updated the message to:
>
> ERROR: enum label "a" used more than once
Nice.
> I also added a test for duplicate enum entries to enum.sql,
> since tests for existing entries are already there.
+1
LGT
Hi Jim,
On Mon, 25 Aug 2025 10:08:23 +0200
Jim Jones wrote:
> Hi Yugo
>
> On 03.07.25 17:04, Yugo Nagata wrote:
> > Currently, when creating an enum type, duplicate labels are caught by a
> > unique
> > index on pg_enum, resulting in a generic error message.
> >
> > postgres=# create type t
Hi Yugo
On 03.07.25 17:04, Yugo Nagata wrote:
> Currently, when creating an enum type, duplicate labels are caught by a unique
> index on pg_enum, resulting in a generic error message.
>
> postgres=# create type t as enum ('a','b','a');
> ERROR: duplicate key value violates unique constraint
Hi Rahila,
On Fri, 4 Jul 2025 07:42:58 +0530
Rahila Syed wrote:
> Thank you for sharing the patch.
> +1 to the idea of improving the error message.
Thank you for your review.
> Please take the following points mentioned into consideration.
>
> 1. I’m considering whether there might be a more
Hi Yugo,
> Currently, when creating an enum type, duplicate labels are caught by a
> unique
> index on pg_enum, resulting in a generic error message.
>
> postgres=# create type t as enum ('a','b','a');
> ERROR: duplicate key value violates unique constraint
> "pg_enum_typid_label_index"
> DE
