Re: Improve prep_buildtree

2025-08-04 Thread Peter Eisentraut
On 31.07.25 09:24, Nazir Bilal Yavuz wrote: On Wed, 30 Jul 2025 at 21:56, Peter Eisentraut wrote: On 30.07.25 12:58, Nazir Bilal Yavuz wrote: That makes sense. I noticed one difference, patched prep_buildtree does not create a symbolic link for the top Makefile in the builddir. Ok, here is

Re: Improve prep_buildtree

2025-07-31 Thread Nazir Bilal Yavuz
Hi, On Wed, 30 Jul 2025 at 21:56, Peter Eisentraut wrote: > > On 30.07.25 12:58, Nazir Bilal Yavuz wrote: > > > > That makes sense. I noticed one difference, patched prep_buildtree > > does not create a symbolic link for the top Makefile in the builddir. > > Ok, here is an updated version that ta

Re: Improve prep_buildtree

2025-07-30 Thread Peter Eisentraut
On 30.07.25 12:58, Nazir Bilal Yavuz wrote: Hi, On Wed, 30 Jul 2025 at 12:32, Peter Eisentraut wrote: On 30.07.25 10:28, Nazir Bilal Yavuz wrote: On Wed, 30 Jul 2025 at 11:07, Peter Eisentraut wrote: To fix this, I first tried to devise a way to detect whether a given directory is a build

Re: Improve prep_buildtree

2025-07-30 Thread Jacob Champion
On Wed, Jul 30, 2025 at 6:35 AM Tom Lane wrote: > For this purpose, I think it's better for us to rely on things we > control than things Meson controls. Adding a new top-level directory > is rare enough that I don't see a problem with needing to update > prep_buildtree. +1. (This approach shoul

Re: Improve prep_buildtree

2025-07-30 Thread Tom Lane
Peter Eisentraut writes: > On 30.07.25 10:28, Nazir Bilal Yavuz wrote: >> Meson looks for ${builddir}/meson-private/coredata.dat file to >> understand if the directory is a build directory [1]. I am just >> wondering if you tried this and found it complicated or did you try >> something else. > I

Re: Improve prep_buildtree

2025-07-30 Thread Nazir Bilal Yavuz
Hi, On Wed, 30 Jul 2025 at 12:32, Peter Eisentraut wrote: > > On 30.07.25 10:28, Nazir Bilal Yavuz wrote: > > On Wed, 30 Jul 2025 at 11:07, Peter Eisentraut wrote: > >> > >> To fix this, I first tried to devise a way to detect whether a given > >> directory is a build directory. But that seemed

Re: Improve prep_buildtree

2025-07-30 Thread Peter Eisentraut
On 30.07.25 10:28, Nazir Bilal Yavuz wrote: On Wed, 30 Jul 2025 at 11:07, Peter Eisentraut wrote: To fix this, I first tried to devise a way to detect whether a given directory is a build directory. But that seemed pretty complicated. Instead, I chose the simpler solution that we just enumera

Re: Improve prep_buildtree

2025-07-30 Thread Nazir Bilal Yavuz
Hi, Thank you for working on this! On Wed, 30 Jul 2025 at 11:07, Peter Eisentraut wrote: > > To fix this, I first tried to devise a way to detect whether a given > directory is a build directory. But that seemed pretty complicated. > Instead, I chose the simpler solution that we just enumerate