Re: Inherited UPDATE/DELETE vs async execution

2021-05-13 Thread Amit Langote
On Thu, May 13, 2021 at 8:10 PM Etsuro Fujita wrote: > On Thu, May 13, 2021 at 5:00 PM Etsuro Fujita wrote: > > On Thu, May 13, 2021 at 3:32 PM Amit Langote > > wrote: > > > On Wed, May 12, 2021 at 6:45 PM Etsuro Fujita > > > wrote: > > > > Here is a rebased version of the patch. I'm plannin

Re: Inherited UPDATE/DELETE vs async execution

2021-05-13 Thread Etsuro Fujita
On Thu, May 13, 2021 at 5:00 PM Etsuro Fujita wrote: > > On Thu, May 13, 2021 at 3:32 PM Amit Langote wrote: > > On Wed, May 12, 2021 at 6:45 PM Etsuro Fujita > > wrote: > > > Here is a rebased version of the patch. I'm planning to apply this > > > tommorow. > > > > + /* > > +* Finally,

Re: Inherited UPDATE/DELETE vs async execution

2021-05-13 Thread Etsuro Fujita
On Thu, May 13, 2021 at 3:32 PM Amit Langote wrote: > On Wed, May 12, 2021 at 6:45 PM Etsuro Fujita wrote: > > Here is a rebased version of the patch. I'm planning to apply this > > tommorow. > > + /* > +* Finally, unset the async-capable flag if it is set. > +*/ > > Would it make sen

Re: Inherited UPDATE/DELETE vs async execution

2021-05-12 Thread Amit Langote
On Wed, May 12, 2021 at 6:45 PM Etsuro Fujita wrote: > On Tue, May 11, 2021 at 9:53 PM Amit Langote wrote: > > Okay, so I take it that making these ForeignScan nodes (that only > > fetch the data) asynchronous doesn't interfere with update/delete > > subsequently being performed over presumably t

Re: Inherited UPDATE/DELETE vs async execution

2021-05-12 Thread Etsuro Fujita
Amit-san, On Tue, May 11, 2021 at 9:53 PM Amit Langote wrote: > On Tue, May 11, 2021 at 5:56 PM Etsuro Fujita wrote: > > On Mon, May 10, 2021 at 9:21 PM Amit Langote > > wrote: > > > On Sat, May 8, 2021 at 1:21 AM Etsuro Fujita > > > wrote: > > > > To > > > > fix, I think we should modify

Re: Inherited UPDATE/DELETE vs async execution

2021-05-11 Thread Amit Langote
Fujita-san, On Tue, May 11, 2021 at 5:56 PM Etsuro Fujita wrote: > On Mon, May 10, 2021 at 9:21 PM Amit Langote wrote: > > On Sat, May 8, 2021 at 1:21 AM Etsuro Fujita > > wrote: > > > I noticed this while working on the > > > EXPLAIN-ANALYZE-for-async-capable-nodes issue: > > > > > > EXPLAIN

Re: Inherited UPDATE/DELETE vs async execution

2021-05-11 Thread Etsuro Fujita
Amit-san, On Mon, May 10, 2021 at 9:21 PM Amit Langote wrote: > On Sat, May 8, 2021 at 1:21 AM Etsuro Fujita wrote: > > I noticed this while working on the > > EXPLAIN-ANALYZE-for-async-capable-nodes issue: > > > > EXPLAIN (VERBOSE, COSTS OFF) > > DELETE FROM async_pt; > >

Re: Inherited UPDATE/DELETE vs async execution

2021-05-10 Thread Amit Langote
Fujita-san, On Sat, May 8, 2021 at 1:21 AM Etsuro Fujita wrote: > I noticed this while working on the > EXPLAIN-ANALYZE-for-async-capable-nodes issue: > > EXPLAIN (VERBOSE, COSTS OFF) > DELETE FROM async_pt; >QUERY PLAN > ---

Re: Inherited UPDATE/DELETE vs async execution

2021-05-09 Thread Etsuro Fujita
On Mon, May 10, 2021 at 9:20 AM Justin Pryzby wrote: > On Sat, May 08, 2021 at 01:20:51AM +0900, Etsuro Fujita wrote: > > I noticed this while working on the > > EXPLAIN-ANALYZE-for-async-capable-nodes issue: > > > > DELETE FROM async_pt; > > server closed the connection unexpectedly > > Confirmed

Re: Inherited UPDATE/DELETE vs async execution

2021-05-09 Thread Justin Pryzby
On Sat, May 08, 2021 at 01:20:51AM +0900, Etsuro Fujita wrote: > I noticed this while working on the > EXPLAIN-ANALYZE-for-async-capable-nodes issue: > > DELETE FROM async_pt; > server closed the connection unexpectedly Confirmed, +Tomas, and added at https://wiki.postgresql.org/wiki/PostgreSQL_1