Re: Injection Points remaining stats

2024-08-22 Thread Michael Paquier
On Thu, Aug 22, 2024 at 01:16:37PM -0400, Yogesh Sharma wrote: > On 8/18/24 20:09, Michael Paquier wrote: >> I'm tempted to propose a separate improvement for the template of the >> fixed-numbered stats. We could do like pgstatfuncs.c where we use a >> macro to define the routines of the counters,

Re: Injection Points remaining stats

2024-08-22 Thread Yogesh Sharma
On 8/18/24 20:09, Michael Paquier wrote: f68cd847fa40 but I've just lacked a combination of time and energy while the original commit was already enough. The code indentation was a bit incorrect, and I think that we should also have tests to stress that the insertion of the new stats is correct.

Re: Injection Points remaining stats

2024-08-18 Thread Michael Paquier
On Mon, Aug 12, 2024 at 10:25:13AM -0400, Yogesh Sharma wrote: > Attaching a patch to add remaining cached and loaded stats as mentioned in > commit f68cd847fa40ead44a786b9c34aff9ccc048004b message. Existing TAP tests > were updated to handle new stats. This patch has been tested on HEAD using > "m