Re: List TAP test files in makefiles

2025-08-31 Thread Peter Eisentraut
On 23.08.25 08:09, Peter Eisentraut wrote: meson.build files have to list TAP test files explicitly.  Makefiles have been relying on a t/*.pl wildcard.  As a consequence, it is traditional now that many developers who are primarily using make forget to add any new TAP test files to the respecti

Re: List TAP test files in makefiles

2025-08-27 Thread Álvaro Herrera
On 2025-Aug-25, Andres Freund wrote: > Unless somebody else volunteers (please!), I guess I should write up a > patch... Maybe it doesn't have to be a patch -- we have some info on command lines to use for testing at https://wiki.postgresql.org/wiki/Meson#Test_related_commands which can perhaps b

Re: List TAP test files in makefiles

2025-08-25 Thread Andres Freund
Hi, On 2025-08-23 12:11:51 -0400, Tom Lane wrote: > Andres Freund writes: > > FWIW, I find the autoconf/make test run experience completely unusable. It > > literally is made me embark on getting away from it. I don't understand how > > people stand it. > > Interesting perspective, because from w

Re: List TAP test files in makefiles

2025-08-23 Thread Tom Lane
Andres Freund writes: > FWIW, I find the autoconf/make test run experience completely unusable. It > literally is made me embark on getting away from it. I don't understand how > people stand it. Interesting perspective, because from where I sit the testing aspect is the weakest part of our meson

Re: List TAP test files in makefiles

2025-08-23 Thread Andrew Dunstan
On 2025-08-23 Sa 10:38 AM, Andres Freund wrote: Hi, On 2025-08-23 10:17:59 -0400, Tom Lane wrote: We should be striving to make the meson system as easy to use as autoconf/make, not trying to attain parity by making the latter experience worse. FWIW, I find the autoconf/make test run experi

Re: List TAP test files in makefiles

2025-08-23 Thread Andres Freund
Hi, On 2025-08-23 10:17:59 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2025-08-23 11:57:37 +0500, Andrey Borodin wrote: > >> What is the downside of the approach where meson uses t/*.pl wildcard? > > > In meson you can't do wildcards at "configure" time, since wildcards do not > > allo

Re: List TAP test files in makefiles

2025-08-23 Thread Tom Lane
Andres Freund writes: > On 2025-08-23 11:57:37 +0500, Andrey Borodin wrote: >> What is the downside of the approach where meson uses t/*.pl wildcard? > In meson you can't do wildcards at "configure" time, since wildcards do not > allow reliable detection of when re-configure is needed. But ... w

Re: List TAP test files in makefiles

2025-08-23 Thread Andres Freund
Hi, On 2025-08-23 11:57:37 +0500, Andrey Borodin wrote: > I agree that this difference between meson and autotools builds is kind of > problematic. > > > On 23 Aug 2025, at 11:09, Peter Eisentraut wrote: > > > > The obvious solution is to also require the makefiles to list TAP files > > expli

Re: List TAP test files in makefiles

2025-08-22 Thread Andrey Borodin
I agree that this difference between meson and autotools builds is kind of problematic. > On 23 Aug 2025, at 11:09, Peter Eisentraut wrote: > > The obvious solution is to also require the makefiles to list TAP files > explicitly, which is what I'm proposing here. What is the downside of the a