On Wed, 3 Jul 2019 at 10:01, Michael Paquier wrote:
> On Tue, Jul 02, 2019 at 02:10:11PM +0900, Michael Paquier wrote:
> > OK, committed to HEAD for now after perltidy'ing the patch. Let's see
> > what the buildfarm has to say about it first. Once we are sure that
> > the thing is stable, I'll
On Tue, Jul 02, 2019 at 02:10:11PM +0900, Michael Paquier wrote:
> OK, committed to HEAD for now after perltidy'ing the patch. Let's see
> what the buildfarm has to say about it first. Once we are sure that
> the thing is stable, I'll try to backpatch it. This works on my own
> dev machines
On Mon, Jul 01, 2019 at 07:56:29PM +1000, Haribabu Kommi wrote:
> We stopped the support of building with all the visual studio versions less
> than 2013. I updated the SDK versions accordingly.
I have spent some time looking around, and wikipedia-sensei has proved
to be helpful to grasp the
On Thu, 27 Jun 2019 at 17:28, Michael Paquier wrote:
> On Wed, Jun 26, 2019 at 10:29:05PM +1000, Haribabu Kommi wrote:
> > Thanks for the review. Yes, that patch applies till 9.5, it is my mistake
> > in naming the patch.
>
> I have been able to finally set up an environment with VS 2019 (as
>
On Wed, Jun 26, 2019 at 10:29:05PM +1000, Haribabu Kommi wrote:
> Thanks for the review. Yes, that patch applies till 9.5, it is my mistake
> in naming the patch.
I have been able to finally set up an environment with VS 2019 (as
usual this stuff needs time, anyway..), and I can confirm that the
On Wed, 5 Jun 2019 at 17:22, Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> wrote:
>
> On Wed, May 29, 2019 at 10:30 AM Haribabu Kommi
> wrote:
>
>>
>> Updated patches are attached.
>>
>>
> All patches apply, build and pass tests. The patch
>
On Wed, May 29, 2019 at 10:30 AM Haribabu Kommi
wrote:
>
> Updated patches are attached.
>
>
All patches apply, build and pass tests. The patch
'0001-support-building-with-visual-studio-2019_v10_to_v9.6_v3.patch'
applies on version 9.5.
Not sure if more review is needed before moving to 'ready
On Mon, May 27, 2019 at 8:14 PM Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> wrote:
>
> On Thu, May 23, 2019 at 3:44 AM Haribabu Kommi
> wrote:
>
>>
>> Updated patches are attached for all branches.
>>
>>
> I have gone through all patches and there are a couple of typos:
>
Thanks
On Thu, May 23, 2019 at 3:44 AM Haribabu Kommi
wrote:
>
> Updated patches are attached for all branches.
>
>
I have gone through all patches and there are a couple of typos:
1. s/prodcutname/productname/
1.1 In file: 0001-support-building-with-visual-studio-2019_v9.4.patch
@@ -97,8
On Wed, May 22, 2019 at 7:36 AM Juanjo Santamaria Flecha <
juanjo.santama...@gmail.com> wrote:
> I have gone through path
> '0001-Support-building-with-visual-studio-2019.patch' only, but I am sure
> some comments will also apply to back branches.
>
Thanks for the review.
> 1. The
I have gone through path '0001-Support-building-with-visual-studio-2019.patch'
only, but I am sure some comments will also apply to back branches.
1. The VisualStudioVersion value looks odd:
+ $self->{VisualStudioVersion}= '16.0.32.32432';
Are you using a pre-release version [1]?
> On Wed, Mar 27, 2019 at 11:42 AM Haribabu Kommi
> wrote:
>
> Visual Studio 2019 is officially released. There is no major change in the
> patch, except some small comments update.
>
> Also attached patches for the back branches also.
>
I have gone through path
On Wed, Mar 27, 2019 at 11:42 AM Haribabu Kommi
wrote:
>
> On Wed, Mar 27, 2019 at 3:03 AM Andrew Dunstan <
> andrew.duns...@2ndquadrant.com> wrote:
>
>>
>> On 3/20/19 8:36 PM, Haribabu Kommi wrote:
>> > Hi Hackers,
>> >
>> > Here I attached a patch that supports building of PostgreSQL with VS
On Wed, Mar 27, 2019 at 3:03 AM Andrew Dunstan <
andrew.duns...@2ndquadrant.com> wrote:
>
> On 3/20/19 8:36 PM, Haribabu Kommi wrote:
> > Hi Hackers,
> >
> > Here I attached a patch that supports building of PostgreSQL with VS
> 2019.
> > VS 2019 is going to release on Apr 2nd 2019, it will be
On 3/20/19 8:36 PM, Haribabu Kommi wrote:
> Hi Hackers,
>
> Here I attached a patch that supports building of PostgreSQL with VS 2019.
> VS 2019 is going to release on Apr 2nd 2019, it will be good if version 12
> supports compiling. The attached for is for review, it may needs some
> updates
>
I
On 3/25/19 3:44 PM, Andrew Dunstan wrote:
> On 3/21/19 3:13 AM, Michael Paquier wrote:
>> On Thu, Mar 21, 2019 at 12:45:57PM +1100, Haribabu Kommi wrote:
>>> The commit f2ab389 is later back-patch to version till 9.3 in commit
>>> 19acfd65. I guess that building the windows installer for all
On 3/21/19 3:13 AM, Michael Paquier wrote:
> On Thu, Mar 21, 2019 at 12:45:57PM +1100, Haribabu Kommi wrote:
>> The commit f2ab389 is later back-patch to version till 9.3 in commit
>> 19acfd65. I guess that building the windows installer for all the
>> versions using the same visual studio is
On Thu, Mar 21, 2019 at 12:45:57PM +1100, Haribabu Kommi wrote:
> The commit f2ab389 is later back-patch to version till 9.3 in commit
> 19acfd65. I guess that building the windows installer for all the
> versions using the same visual studio is may be the reason behind
> that back-patch.
I did
On Thu, Mar 21, 2019 at 12:31 PM Michael Paquier
wrote:
> On Thu, Mar 21, 2019 at 09:47:02AM +0900, Michael Paquier wrote:
> > When it comes to support newer versions of MSVC, we have come up
> > lately to backpatch that down to two stable versions but not further
> > down (see f2ab389 for v10
On Thu, Mar 21, 2019 at 09:47:02AM +0900, Michael Paquier wrote:
> When it comes to support newer versions of MSVC, we have come up
> lately to backpatch that down to two stable versions but not further
> down (see f2ab389 for v10 and v9.6), so it looks sensible to target
> v11 and v10 as well if
On Thu, Mar 21, 2019 at 11:36:42AM +1100, Haribabu Kommi wrote:
> I can provide a separate back branches patch later once this patch comes to
> a stage of commit. Currently all the supported branches are possible to
> compile with VS 2017.
When it comes to support newer versions of MSVC, we have
21 matches
Mail list logo
