On Tue, Mar 9, 2021 at 3:41 PM Markus Wanner
wrote:
>
> On 09.03.21 10:37, Amit Kapila wrote:
> I guess I don't quite understand the initial motivation for the patch.
> It states: "This allows plugins to not allow the enabling of streaming
> and two_phase at the same time in logical replication."
On 09.03.21 10:37, Amit Kapila wrote:
AFAICS, the error is removed by the patch as per below change:
Ah, well, that does not seem right, then. We cannot just silently
ignore the callback but not skip the prepare, IMO. That would lead to
the output plugin missing the PREPARE, but still seein
On Tue, Mar 9, 2021 at 2:23 PM Markus Wanner wrote:
>
> On 09.03.21 09:39, Amit Kapila wrote:
> > It is attached with the initial email.
>
> Oh, sorry, I looked up the initial email, but still didn't see the patch.
>
> > I think so. The behavior has to be similar to other optional callbacks
> > l
On 09.03.21 09:39, Amit Kapila wrote:
> It is attached with the initial email.
Oh, sorry, I looked up the initial email, but still didn't see the patch.
I think so. The behavior has to be similar to other optional callbacks
like message_cb, truncate_cb, stream_truncate_cb. Basically, we don't
n
On Tue, Mar 9, 2021 at 1:55 PM Markus Wanner
wrote:
>
> On 09.03.21 07:40, Amit Kapila wrote:
> > Sounds reasonable to me. I also don't see a reason why we need to make
> > this a necessary callback. Some plugin authors might just want 2PC
> > without streaming support.
>
> Sounds okay to me. Pro
On 09.03.21 07:40, Amit Kapila wrote:
Sounds reasonable to me. I also don't see a reason why we need to make
this a necessary callback. Some plugin authors might just want 2PC
without streaming support.
Sounds okay to me. Probably means we'll have to check for this callback
and always skip th
On Mon, Mar 8, 2021 at 2:43 PM Ajin Cherian wrote:
>
> Hi Hackers,
>
> As part of commit 0aa8a0 , new plugin methods (callbacks) were defined for
> enabling two_phase commits.
> 5 callbacks were required:
> * begin_prepare
> * prepare
> * commit_prepared
> * rollback_prepared
> * stream_prepare
>
