Re: New "blob" re-introduced?

2023-02-23 Thread Daniel Gustafsson
> On 24 Feb 2023, at 08:40, Kyotaro Horiguchi wrote: > Mmm. The following changes of e9960732a9 seem like reverting the > previous commit 35ce24c333... Fixed in 94851e4b90, thanks for the report! -- Daniel Gustafsson

Re: New "blob" re-introduced?

2023-02-23 Thread Kyotaro Horiguchi
At Fri, 24 Feb 2023 16:31:27 +0900 (JST), Kyotaro Horiguchi wrote in > I noticed that the commit e9960732a9 introduced the following message. > > + if (EndCompressFileHandle(ctx->dataFH) != 0) > + pg_fatal("could not close blob data file: %m"); > > It seems that we have

Re: New "blob" re-introduced?

2023-02-23 Thread Daniel Gustafsson
> On 24 Feb 2023, at 08:31, Kyotaro Horiguchi wrote: > Shouldn't we use "large object" instead of "blob" in the message? Nice catch, it should be "large object" as per the linked discussion. There are also a few more like: - if (cfclose(ctx->LOsTocFH) != 0) -