Re: Non-blocking archiver process

2025-11-19 Thread Robert Haas
On Wed, Nov 12, 2025 at 6:57 AM BharatDB wrote: > Dear Evan and PostgreSQL community, 1. Please stop sending AI-generated emails and patches to this list. If you want to use an AI tool to help you generate emails and patches, that's fine with me. (I can't speak for anyone else.) But you're clearl

Re: Non-blocking archiver process

2025-11-12 Thread BharatDB
Dear Evan and PostgreSQL community, Thank you for the feedback and for reporting the build failure. I have prepared v2 of the patch, which fixes the issues you mentioned: - Replaced the incorrect include `#include "latch.h"` with `#include "storage/latch.h"`, fixing the macOS build failure. - W

Re: Non-blocking archiver process

2025-11-11 Thread Chao Li
> On Nov 10, 2025, at 18:41, BharatDB wrote: > > Dear PostgreSQL Community, > I found 8 Bugs in `shell_archive.c` > > While studying how `archive_command` works, I discovered **8 real issues** > that affect reliability, performance, and safety: > | # | Bug | Impact | |---|-||

Re: Non-blocking archiver process

2025-11-10 Thread BharatDB
Dear PostgreSQL Community, I found 8 Bugs in `shell_archive.c` While studying how `archive_command` works, I discovered **8 real issues** that affect reliability, performance, and safety: | # | Bug | Impact | |---|-|| | 1 | Infinite loop on command failure | Archiver hangs forever |

Re: Non-blocking archiver process

2025-10-14 Thread Robert Haas
Here are a few comments from me: I think that by calling system(), anything that is printed out by the child process ends up in the PostgreSQL log. With the patch, the output of the command seems like it will be read into a buffer and discarded. That's a significant behavior difference. This patc

Re: Non-blocking archiver process

2025-09-25 Thread Artem Gavrilov
Hello Patrick I did a review of your patch. Initial Run === The patch applies cleanly to HEAD (196063d6761). All tests successfully pass on MacOS 15.7. Comments === 1) Instead of `malloc` and `free` it should be `palloc` and `pfree`. 2) In fact `archiveFileno` is a file descript

Re: Non-blocking archiver process

2025-07-27 Thread Patrick Stählin
On 05.07.25 05:01, Noah Misch wrote: On Fri, Jul 04, 2025 at 08:46:08AM +0200, Ronan Dunklau wrote: We've noticed a behavior that seems surprising to us. Since DROP DATABASE now waits for a ProcSignalBarrier, it can hang up indefinitely if the archive_command hangs. The reason for this is that

Re: Non-blocking archiver process

2025-07-04 Thread Noah Misch
On Fri, Jul 04, 2025 at 08:46:08AM +0200, Ronan Dunklau wrote: > We've noticed a behavior that seems surprising to us. > Since DROP DATABASE now waits for a ProcSignalBarrier, it can hang up > indefinitely if the archive_command hangs. > > The reason for this is that the builtin archive module