Re: Optimization of some jsonb functions

2019-09-20 Thread Alvaro Herrera
I pushed the first few parts. The attached is a rebased copy of the last remaining piece. However, I didn't quite understand what this was doing, so I refrained from pushing. I think there are two patches here: one that adapts the API of findJsonbValueFromContainer and

Re: Optimization of some jsonb functions

2019-09-18 Thread Alvaro Herrera
On 2019-Sep-19, Alvaro Herrera wrote: > On 2019-Sep-18, Alvaro Herrera wrote: > > > Well, I think that was useless, so I rebased again -- attached. > > ... which is how you find out that 0001 as an independent patch is not > really a valid one, since it depends on an API change that does not >

Re: Optimization of some jsonb functions

2019-09-18 Thread Alvaro Herrera
On 2019-Sep-18, Alvaro Herrera wrote: > Well, I think that was useless, so I rebased again -- attached. ... which is how you find out that 0001 as an independent patch is not really a valid one, since it depends on an API change that does not happen until 0005. -- Álvaro Herrera

Re: Optimization of some jsonb functions

2019-09-18 Thread Alvaro Herrera
On 2019-Jul-26, Joe Nelson wrote: > Thomas Munro wrote: > > This doesn't apply -- to attract reviewers, could we please have a rebase? > > To help the review go forward, I have rebased the patch on 27cd521e6e. > It passes `make check` for me, but that's as far as I've verified the > correctness.

Re: Optimization of some jsonb functions

2019-07-26 Thread Joe Nelson
Thomas Munro wrote: > This doesn't apply -- to attract reviewers, could we please have a rebase? To help the review go forward, I have rebased the patch on 27cd521e6e. It passes `make check` for me, but that's as far as I've verified the correctness. I squashed the changes into a single patch,

Re: Optimization of some jsonb functions

2019-07-01 Thread Thomas Munro
> >> On 2/22/19 2:05 AM, Nikita Glukhov wrote: > >>> Attached set of patches with some jsonb optimizations that were made > >>> during > >>> comparison of performance of ordinal jsonb operators and jsonpath > >>> operators. Hi Nikita, This doesn't apply -- to attract reviewers, could we please

Re: Optimization of some jsonb functions

2019-03-07 Thread David Steele
Hi Andrew, On 3/6/19 9:50 PM, Andrew Dunstan wrote: On 3/5/19 5:24 AM, David Steele wrote: On 2/22/19 2:05 AM, Nikita Glukhov wrote: Attached set of patches with some jsonb optimizations that were made during comparison of performance of ordinal jsonb operators and jsonpath operators. This

Re: Optimization of some jsonb functions

2019-03-06 Thread Andrew Dunstan
On 3/5/19 5:24 AM, David Steele wrote: > On 2/22/19 2:05 AM, Nikita Glukhov wrote: >> Attached set of patches with some jsonb optimizations that were made >> during >> comparison of performance of ordinal jsonb operators and jsonpath >> operators. > > This patch was submitted just before the

Re: Optimization of some jsonb functions

2019-03-05 Thread David Steele
On 2/22/19 2:05 AM, Nikita Glukhov wrote: Attached set of patches with some jsonb optimizations that were made during comparison of performance of ordinal jsonb operators and jsonpath operators. This patch was submitted just before the last commitfest for PG12 and seems to have potential for