Re: Preserve versions of initdb-created collations in pg_upgrade

2020-01-24 Thread Peter Eisentraut
On 2019-12-21 09:01, Thomas Munro wrote: I think this problem goes away if we commit the per-object collation version patch set[1]. It drops the collversion column, and Julien's recent versions handle pg_upgrade quite well, as long as a collation by the same name exists in the target cluster. I

Re: Preserve versions of initdb-created collations in pg_upgrade

2019-12-21 Thread Thomas Munro
On Sat, Dec 21, 2019 at 7:38 PM Peter Eisentraut wrote: > On 2019-10-29 03:33, Thomas Munro wrote: > > Seems to work as described with -E UTF-8, but it fails with clusters > > using -E SQL_ASCII. That causes the pg_upgrade check to fail on > > machines where that is the default encoding chosen by

Re: Preserve versions of initdb-created collations in pg_upgrade

2019-12-20 Thread Peter Eisentraut
On 2019-10-29 03:33, Thomas Munro wrote: Seems to work as described with -E UTF-8, but it fails with clusters using -E SQL_ASCII. That causes the pg_upgrade check to fail on machines where that is the default encoding chosen by initdb (where unpatched master succeeds): pg_restore: creating COLL

Re: Preserve versions of initdb-created collations in pg_upgrade

2019-10-28 Thread Thomas Munro
On Tue, Oct 29, 2019 at 1:52 AM Peter Eisentraut wrote: > As mentioned in [0], pg_upgrade currently does not preserve the version > of collation objects created by initdb. Here is an attempt to fix that. > > The way I deal with this here is by having the binary-upgrade mode in > pg_dump delete al