Re: Re: [HACKERS] Support to COMMENT ON DATABASE CURRENT_DATABASE

2018-03-06 Thread Alvaro Herrera
David Steele wrote: > On 3/1/18 2:09 PM, Tom Lane wrote: > > > TBH, I think we should reject this patch. While it's not huge, > > it's not trivial either, and I find the grammar changes rather ugly. > > The argument for using the feature to fix pg_dump issues has evaporated, > > but I don't see

Re: Re: [HACKERS] Support to COMMENT ON DATABASE CURRENT_DATABASE

2018-03-06 Thread David Steele
Hi Jing, On 3/1/18 2:09 PM, Tom Lane wrote: > Jing Wang writes: >> [ support_CURRENT_DATABASE_keyword_v4.7.patch ] > > TBH, I think we should reject this patch. While it's not huge, > it's not trivial either, and I find the grammar changes rather ugly. > The argument for