Re: Regression test coverage of GiST index build is awful

2019-04-24 Thread Tom Lane
Alexander Korotkov writes: > On Wed, Apr 24, 2019 at 9:31 PM Tom Lane wrote: >> Why is this so bad? It's not like the gist regression test isn't >> ridiculously expensive already; I'd have expected it to provide >> darn near 100% coverage for what it's costing in runtime. > I don't think there

Re: Regression test coverage of GiST index build is awful

2019-04-24 Thread Alexander Korotkov
On Wed, Apr 24, 2019 at 9:31 PM Tom Lane wrote: > This tells a pretty scary story: > > https://coverage.postgresql.org/src/backend/access/gist/index.html > > In particular, gistbuildbuffers.c is not entered *at all*, and > gistbuild.c is only 21% covered. > > I noticed this after adding an