On Sun, Oct 22, 2023 at 11:59:00PM +0530, Bharath Rupireddy wrote:
> AFAICS, there's no correctness argument for breaking before CFI. As
> rightly said, CFIs can happen before the break condition either down
> inside LogicalDecodingProcessRecord or XLogReadRecord (page_read
> callbacks for instance
On Sat, Oct 21, 2023 at 11:40 PM Tom Lane wrote:
>
> Gurjeet Singh writes:
> > On Fri, Oct 20, 2023 at 7:30 PM Bharath Rupireddy
> > wrote:
> >> There exists an extraneous break condition in
> >> pg_logical_replication_slot_advance(). When the end of WAL or moveto
> >> LSN is reached, the main w
Gurjeet Singh writes:
> On Fri, Oct 20, 2023 at 7:30 PM Bharath Rupireddy
> wrote:
>> There exists an extraneous break condition in
>> pg_logical_replication_slot_advance(). When the end of WAL or moveto
>> LSN is reached, the main while condition helps to exit the loop, so no
>> separate break c
On Fri, Oct 20, 2023 at 7:30 PM Bharath Rupireddy
wrote:
>
> Hi,
>
> There exists an extraneous break condition in
> pg_logical_replication_slot_advance(). When the end of WAL or moveto
> LSN is reached, the main while condition helps to exit the loop, so no
> separate break condition is needed. A
