Re: Reorganize collation lookup time and place

2019-02-01 Thread Peter Geoghegan
On Fri, Feb 1, 2019 at 7:27 AM Peter Eisentraut wrote: > This patch will probably make a reappearance when we consider making ICU > available as the database-wide default collation. Somebody recently reported that an ICU locale was over 2000x faster than the equivalent glibc locale with their que

Re: Reorganize collation lookup time and place

2019-02-01 Thread Peter Eisentraut
On 31/01/2019 13:45, Andres Freund wrote: > So, what's the plan here? Should the CF entry be closed? Set to RwF. This patch will probably make a reappearance when we consider making ICU available as the database-wide default collation. -- Peter Eisentraut http://www.2ndQuadrant.com

Re: Reorganize collation lookup time and place

2019-01-31 Thread Andres Freund
Hi, On 2018-12-13 14:50:53 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2018-12-13 15:05:40 +0100, Peter Eisentraut wrote: > >> On 12/12/2018 18:56, Andres Freund wrote: > >>> Why isn't this integrated into fmgr_info()? > > >> fmgr_info() looks up stuff in pg_proc. pg_newlocale_...() l

Re: Reorganize collation lookup time and place

2018-12-13 Thread Andres Freund
On 2018-12-13 14:50:53 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2018-12-13 15:05:40 +0100, Peter Eisentraut wrote: > >> On 12/12/2018 18:56, Andres Freund wrote: > >>> Why isn't this integrated into fmgr_info()? > > >> fmgr_info() looks up stuff in pg_proc. pg_newlocale_...() looks

Re: Reorganize collation lookup time and place

2018-12-13 Thread Tom Lane
Andres Freund writes: > On 2018-12-13 15:05:40 +0100, Peter Eisentraut wrote: >> On 12/12/2018 18:56, Andres Freund wrote: >>> Why isn't this integrated into fmgr_info()? >> fmgr_info() looks up stuff in pg_proc. pg_newlocale_...() looks up >> stuff in pg_collation. There is no overlap between

Re: Reorganize collation lookup time and place

2018-12-13 Thread Andres Freund
Hi, On 2018-12-13 15:05:40 +0100, Peter Eisentraut wrote: > On 12/12/2018 18:56, Andres Freund wrote: > >> This makes the collation lookup more similar to the function lookup. In > >> many cases they now happen right next to each other. > >> pg_newlocale_from_collation() becomes analogous to fmgr

Re: Reorganize collation lookup time and place

2018-12-13 Thread Peter Eisentraut
On 12/12/2018 18:56, Andres Freund wrote: >> This makes the collation lookup more similar to the function lookup. In >> many cases they now happen right next to each other. >> pg_newlocale_from_collation() becomes analogous to fmgr_info() and >> pg_locale_t to FmgrInfo *. > Why isn't this integrat

Re: Reorganize collation lookup time and place

2018-12-12 Thread Andres Freund
Hi, On 2018-12-10 16:12:54 +0100, Peter Eisentraut wrote: > Attached is a patch that reorganizes how and where collations are looked up. > > Until now, a fmgr C function that makes use of collation information > (for example varstr_cmp(), str_toupper()) gets passed the collation OID, > looks up t

Re: Reorganize collation lookup time and place

2018-12-12 Thread Andreas Karlsson
On 12/10/18 4:12 PM, Peter Eisentraut wrote: Attached is a patch that reorganizes how and where collations are looked up. Until now, a fmgr C function that makes use of collation information (for example varstr_cmp(), str_toupper()) gets passed the collation OID, looks up the collation with pg_n