Re: Report bytes and transactions actually sent downtream

2025-09-19 Thread Ashutosh Bapat
On Fri, Sep 19, 2025 at 11:48 AM shveta malik wrote: > > On Thu, Sep 18, 2025 at 3:54 PM Ashutosh Bapat > wrote: > > > > > > > > > > Few comments: > > > > > > 1) > > > postgres=# select slot_name, > > > total_bytes,plugin_filtered_bytes,plugin_sent_bytes from > > > pg_stat_replication_slots orde

Re: Report bytes and transactions actually sent downtream

2025-09-19 Thread shveta malik
On Thu, Sep 18, 2025 at 3:54 PM Ashutosh Bapat wrote: > > > > > > Few comments: > > > > 1) > > postgres=# select slot_name, > > total_bytes,plugin_filtered_bytes,plugin_sent_bytes from > > pg_stat_replication_slots order by slot_name; > > slot_name | total_bytes | plugin_filtered_bytes | plugin_

Re: Report bytes and transactions actually sent downtream

2025-09-18 Thread Ashutosh Bapat
Hi Shveta, Bertrand, Replying to both of your review comments together. On Thu, Sep 18, 2025 at 10:52 AM shveta malik wrote: > > On Wed, Aug 27, 2025 at 7:14 PM Bertrand Drouvot > wrote: > > > > Hi, > > > > On Thu, Jul 24, 2025 at 12:24:26PM +0530, Ashutosh Bapat wrote: > > > Here's the next pa

Re: Report bytes and transactions actually sent downtream

2025-09-17 Thread shveta malik
On Wed, Aug 27, 2025 at 7:14 PM Bertrand Drouvot wrote: > > Hi, > > On Thu, Jul 24, 2025 at 12:24:26PM +0530, Ashutosh Bapat wrote: > > Here's the next patch which considers all the discussion so far. It > > adds four fields to pg_stat_replication_slots. > > - plugin - name of the output plugi

Re: Report bytes and transactions actually sent downtream

2025-08-27 Thread Bertrand Drouvot
Hi, On Thu, Jul 24, 2025 at 12:24:26PM +0530, Ashutosh Bapat wrote: > Here's the next patch which considers all the discussion so far. It > adds four fields to pg_stat_replication_slots. > - plugin - name of the output plugin Is this one needed? (we could get it with a join on pg_replication_

Re: Report bytes and transactions actually sent downtream

2025-07-23 Thread Ashutosh Bapat
Hi Amit, On Mon, Jul 14, 2025 at 3:31 PM Amit Kapila wrote: > > On Mon, Jul 14, 2025 at 10:55 AM Ashutosh Bapat > wrote: > > > > On Sun, Jul 13, 2025 at 4:34 PM Amit Kapila wrote: > > > > > > > > > I think we don't want to make it mandatory for plugins to implement > > > these stats, so instead

Re: Report bytes and transactions actually sent downtream

2025-07-14 Thread Amit Kapila
On Mon, Jul 14, 2025 at 10:55 AM Ashutosh Bapat wrote: > > On Sun, Jul 13, 2025 at 4:34 PM Amit Kapila wrote: > > > > > > I think we don't want to make it mandatory for plugins to implement > > these stats, so instead of throwing ERROR, the view should show that > > the plugin doesn't provide sta

Re: Report bytes and transactions actually sent downtream

2025-07-13 Thread Ashutosh Bapat
On Sun, Jul 13, 2025 at 4:34 PM Amit Kapila wrote: > > On Tue, Jul 1, 2025 at 7:35 PM Ashutosh Bapat > wrote: > > > > On Tue, Jul 1, 2025 at 4:23 PM Amit Kapila wrote: > > > > > > On Mon, Jun 30, 2025 at 3:24 PM Ashutosh Bapat > > > wrote: > > > > > > > > Hi All, > > > > In a recent logical rep

Re: Report bytes and transactions actually sent downtream

2025-07-13 Thread Amit Kapila
On Tue, Jul 1, 2025 at 7:35 PM Ashutosh Bapat wrote: > > On Tue, Jul 1, 2025 at 4:23 PM Amit Kapila wrote: > > > > On Mon, Jun 30, 2025 at 3:24 PM Ashutosh Bapat > > wrote: > > > > > > Hi All, > > > In a recent logical replication issue, there were multiple replication > > > slots involved, each

Re: Report bytes and transactions actually sent downtream

2025-07-01 Thread Ashutosh Bapat
On Tue, Jul 1, 2025 at 4:23 PM Amit Kapila wrote: > > On Mon, Jun 30, 2025 at 3:24 PM Ashutosh Bapat > wrote: > > > > Hi All, > > In a recent logical replication issue, there were multiple replication > > slots involved, each using a different publication. Thus the amount of > > data that was rep

Re: Report bytes and transactions actually sent downtream

2025-07-01 Thread Amit Kapila
On Mon, Jun 30, 2025 at 3:24 PM Ashutosh Bapat wrote: > > Hi All, > In a recent logical replication issue, there were multiple replication > slots involved, each using a different publication. Thus the amount of > data that was replicated through each slot was expected to be > different. However,