On Mon, Aug 16, 2021 at 4:42 AM Daniel Gustafsson wrote:
>
> > On 30 Jul 2021, at 18:27, Bossart, Nathan wrote:
> >
> > On 7/30/21, 2:22 AM, "Daniel Gustafsson" wrote:
> >> LGTM. I took the liberty to rephrase the "and exit" part of the initdb
> >> help
> >> output match the other exiting
> On 30 Jul 2021, at 18:27, Bossart, Nathan wrote:
>
> On 7/30/21, 2:22 AM, "Daniel Gustafsson" wrote:
>> LGTM. I took the liberty to rephrase the "and exit" part of the initdb help
>> output match the other exiting options in there. Barring objections, I think
>> this is ready.
>
> LGTM.
On 7/30/21, 2:22 AM, "Daniel Gustafsson" wrote:
> LGTM. I took the liberty to rephrase the "and exit" part of the initdb help
> output match the other exiting options in there. Barring objections, I think
> this is ready.
LGTM. Thanks!
Nathan
> On 30 Jul 2021, at 01:37, Bossart, Nathan wrote:
>
> On 7/29/21, 2:11 AM, "Daniel Gustafsson" wrote:
>> I think removing the word "only" here is a net loss, since it IMO clearly
>> conveyed that this option isn't doing any of the other initdb duties. The
>> documentation states it in more
> On 26 Jul 2021, at 20:05, Bossart, Nathan wrote:
> Here are my suggestions in patch form.
- printf(_(" -S, --sync-only only sync data directory\n"));
+ printf(_(" -S, --sync-only safely write all database files
to disk and exit\n"));
I think removing the
On Mon, Jul 26, 2021 at 11:05 AM Bossart, Nathan wrote:
> Here are my suggestions in patch form.
+printf(_(" -S, --sync-only safely write all database
files to disk and exit\n"));
Not your patch's fault, but the word "write" does not seem to convey
the true intent of the option,
On 7/22/21, 6:31 PM, "Justin Pryzby" wrote:
> On Thu, Jul 22, 2021 at 10:32:18PM +, Bossart, Nathan wrote:
>> IMO the note about the option being helpful after using the --no-sync
>> option would fit better in the docs, but I'm struggling to think of a
>> use case for using --no-sync and then
On Thu, Jul 22, 2021 at 10:32:18PM +, Bossart, Nathan wrote:
> On 7/6/21, 7:02 PM, "Gurjeet Singh" wrote:
> > I think it would be helpful if the help message was slightly more
> > descriptive. Some options:
> >
> > Used in patch:
> > only sync data directory; does not modify any data
> >
On 7/6/21, 7:02 PM, "Gurjeet Singh" wrote:
> I think it would be helpful if the help message was slightly more
> descriptive. Some options:
>
> Used in patch:
> only sync data directory; does not modify any data
>
> To match the wording of --sync-only option:
> write contents of data
