Re: Stabilizing the test_decoding checks, take N

2022-04-19 Thread Amit Kapila
On Tue, Apr 19, 2022 at 3:16 PM Amit Kapila wrote: > > On Tue, Apr 19, 2022 at 11:38 AM Dilip Kumar wrote: > > > > On Mon, Apr 18, 2022 at 3:29 PM Dilip Kumar wrote: > > > > > > > > This needs to be verified once by doing some manual testing as it may > > > not be easily reproducible every time.

Re: Stabilizing the test_decoding checks, take N

2022-04-19 Thread Amit Kapila
On Tue, Apr 19, 2022 at 11:38 AM Dilip Kumar wrote: > > On Mon, Apr 18, 2022 at 3:29 PM Dilip Kumar wrote: > > > > > This needs to be verified once by doing some manual testing as it may > > not be easily reproducible every time. If this happens to be true then > > I think your suggestion related

Re: Stabilizing the test_decoding checks, take N

2022-04-18 Thread Dilip Kumar
On Mon, Apr 18, 2022 at 3:29 PM Dilip Kumar wrote: > > This needs to be verified once by doing some manual testing as it may > not be easily reproducible every time. If this happens to be true then > I think your suggestion related to increasing autovacuum_naptime would > work. > > > I will try t

Re: Stabilizing the test_decoding checks, take N

2022-04-18 Thread Dilip Kumar
On Mon, Apr 18, 2022 at 11:19 AM Amit Kapila wrote: > On Sat, Apr 16, 2022 at 10:42 PM Tom Lane wrote: > > > > My pet dinosaur prairiedog just failed in the contrib/test_decoding > > tests [1]: > > > > diff -U3 > /Users/buildfarm/bf-data/HEAD/pgsql.build/contrib/test_decoding/expected/stream.out

Re: Stabilizing the test_decoding checks, take N

2022-04-17 Thread Amit Kapila
On Sat, Apr 16, 2022 at 10:42 PM Tom Lane wrote: > > My pet dinosaur prairiedog just failed in the contrib/test_decoding > tests [1]: > > diff -U3 > /Users/buildfarm/bf-data/HEAD/pgsql.build/contrib/test_decoding/expected/stream.out > > /Users/buildfarm/bf-data/HEAD/pgsql.build/contrib/test_dec

Re: Stabilizing the test_decoding checks, take N

2022-04-17 Thread Amit Kapila
On Sun, Apr 17, 2022 at 8:02 PM Andres Freund wrote: > > Adding Amit, I think this is stuff he worked on... > I'll look into this and share my findings. -- With Regards, Amit Kapila.

Re: Stabilizing the test_decoding checks, take N

2022-04-17 Thread Tom Lane
Andres Freund writes: > On 2022-04-17 12:01:53 -0400, Tom Lane wrote: >> It seems likely to me that trying to make a test like this one blind to >> autovacuum/autoanalyze activity will make it less useful, not more so. >> Why is such blindness desirable? > Maybe I misunderstood - I thought you we

Re: Stabilizing the test_decoding checks, take N

2022-04-17 Thread Andres Freund
Hi On 2022-04-17 12:01:53 -0400, Tom Lane wrote: > Andres Freund writes: > >> On 2022-04-16 13:11:59 -0400, Tom Lane wrote: > >>> We've seen this sort of problem before [2], and attempted to fix it [3] > >>> by making these tests ignore empty transactions. But of course > >>> auto-analyze's tran

Re: Stabilizing the test_decoding checks, take N

2022-04-17 Thread Tom Lane
Andres Freund writes: >> On 2022-04-16 13:11:59 -0400, Tom Lane wrote: >>> We've seen this sort of problem before [2], and attempted to fix it [3] >>> by making these tests ignore empty transactions. But of course >>> auto-analyze's transaction wasn't empty, so that didn't help. >> I don't quite

Re: Stabilizing the test_decoding checks, take N

2022-04-17 Thread Andres Freund
Hi, Adding Amit, I think this is stuff he worked on... On 2022-04-17 07:31:04 -0700, Andres Freund wrote: > On 2022-04-16 13:11:59 -0400, Tom Lane wrote: > > My pet dinosaur prairiedog just failed in the contrib/test_decoding > > tests [1]: > > > > diff -U3 > > /Users/buildfarm/bf-data/HEAD/pgs

Re: Stabilizing the test_decoding checks, take N

2022-04-17 Thread Andres Freund
Hi, On 2022-04-16 13:11:59 -0400, Tom Lane wrote: > My pet dinosaur prairiedog just failed in the contrib/test_decoding > tests [1]: > > diff -U3 > /Users/buildfarm/bf-data/HEAD/pgsql.build/contrib/test_decoding/expected/stream.out > > /Users/buildfarm/bf-data/HEAD/pgsql.build/contrib/test_dec