> On 26 Nov 2025, at 12:11, Dagfinn Ilmari Mannsåker wrote:
> This seems unrelated to the rest of the patch patch.
Yeah, I was working on a docs-patch in the same tree and only realized this
morning that I had accidentally included that part =)
>> diff --git a/src/tools/pgindent/pgperltidy b/sr
Daniel Gustafsson writes:
> [2. text/x-diff; v2_perltidyversion.diff]
> diff --git a/doc/src/sgml/func/func-string.sgml
> b/doc/src/sgml/func/func-string.sgml
> index 7ad1436e5f8..646b5d6d8c4 100644
> --- a/doc/src/sgml/func/func-string.sgml
> +++ b/doc/src/sgml/func/func-string.sgml
> @@ -173,7
> On 25 Nov 2025, at 23:03, Dagfinn Ilmari Mannsåker wrote:
> Even simpler, and avoiding having to move the `set -e` after the check:
>
> PERLTIDY_VERSION=20230309
> if ! $PERLTIDY -v | grep -q $PERLTIDY_VERSION; then
> echo "error: pgperltidy requires perltidy v$PERLTIDY_VERSION"
> exit 1
> fi
On Tue, Nov 25, 2025 at 2:03 PM Dagfinn Ilmari Mannsåker
wrote:
> Even simpler, and avoiding having to move the `set -e` after the check:
+1; you beat me to it by a couple seconds :)
--Jacob
Andrew Dunstan writes:
> On 2025-11-25 Tu 2:36 PM, Daniel Gustafsson wrote:
>>> On 25 Nov 2025, at 20:31, Álvaro Herrera wrote:
>>>
>>> On 2025-Nov-25, Daniel Gustafsson wrote:
>>>
Agreed. Perhaps something like the attached would work?
>>> Hmm, I got this
>>>
>>> src/tools/pgindent/pgperlt
On 2025-11-25 Tu 2:36 PM, Daniel Gustafsson wrote:
On 25 Nov 2025, at 20:31, Álvaro Herrera wrote:
On 2025-Nov-25, Daniel Gustafsson wrote:
Agreed. Perhaps something like the attached would work?
Hmm, I got this
src/tools/pgindent/pgperltidy: 10: [: 0: unexpected operator
$ ls -l /bin/sh
Daniel Gustafsson writes:
>> On 2025-Nov-25, Tom Lane wrote:
>>> pgindent has long had a check that you're running the correct version
>>> of bsdindent, but I just realized that pgperltidy makes no such check
>>> for perltidy. Should we install one?
> Agreed. Perhaps something like the attached
> On 25 Nov 2025, at 20:31, Álvaro Herrera wrote:
>
> On 2025-Nov-25, Daniel Gustafsson wrote:
>
>> Agreed. Perhaps something like the attached would work?
>
> Hmm, I got this
>
> src/tools/pgindent/pgperltidy: 10: [: 0: unexpected operator
>
> $ ls -l /bin/sh
> lrwxrwxrwx 1 root root 4 feb
On 2025-Nov-25, Daniel Gustafsson wrote:
> Agreed. Perhaps something like the attached would work?
Hmm, I got this
src/tools/pgindent/pgperltidy: 10: [: 0: unexpected operator
$ ls -l /bin/sh
lrwxrwxrwx 1 root root 4 feb 4 2025 /bin/sh -> dash*
(Seems to work ok silently with bash.)
--
Ál
> On 25 Nov 2025, at 18:53, Álvaro Herrera wrote:
>
> On 2025-Nov-25, Tom Lane wrote:
>
>> pgindent has long had a check that you're running the correct version
>> of bsdindent, but I just realized that pgperltidy makes no such check
>> for perltidy. Should we install one?
>
> Yeah, we should
On 2025-Nov-25, Tom Lane wrote:
> pgindent has long had a check that you're running the correct version
> of bsdindent, but I just realized that pgperltidy makes no such check
> for perltidy. Should we install one?
Yeah, we should definitely have that.
--
Álvaro HerreraBreisgau, Deutsc
Daniel Gustafsson writes:
> On 25 Nov 2025, at 17:00, Tom Lane wrote:
>> =?utf-8?Q?=C3=81lvaro?= Herrera writes:
>>> Hmm, I wonder if you ran this with our documented version of perltidy.
> ..and since I managed to run it with the wrong version for the attached diff
> that
> argument certainly
> On 25 Nov 2025, at 17:00, Tom Lane wrote:
>
> =?utf-8?Q?=C3=81lvaro?= Herrera writes:
>> On 2025-Nov-25, Daniel Gustafsson wrote:
>>> I routinely run pgperltidy src/ when hacking on things, and am greeted with
>>> lots of diffs like how pgindent runs used to be. Are there objections to
>>> ap
=?utf-8?Q?=C3=81lvaro?= Herrera writes:
> On 2025-Nov-25, Daniel Gustafsson wrote:
>> I routinely run pgperltidy src/ when hacking on things, and am greeted with
>> lots of diffs like how pgindent runs used to be. Are there objections to
>> applying the diffs we've accumulated so far with a .git-
On 2025-Nov-25, Daniel Gustafsson wrote:
> I routinely run pgperltidy src/ when hacking on things, and am greeted with
> lots of diffs like how pgindent runs used to be. Are there objections to
> applying the diffs we've accumulated so far with a .git-blame-ignore-revs
> update alongside it? Are
15 matches
Mail list logo
