> On 14 Nov 2025, at 16:20, Andrew Dunstan wrote:
> OTOH, if you want to skip a lot of ok's in the regress_log file, you can do
> something like:
>
> fail("$line missing initial # in postgresql.conf.sample") if $line =~
> /^\s*[^#\s]/;
Went ahead with a change along this line to keep the test
On Fri, Nov 14, 2025 at 01:01:08PM -0600, Nathan Bossart wrote:
> Since it's my bug, I'll go ahead and apply the fix.
Committed.
--
nathan
On Fri, Nov 14, 2025 at 08:57:46AM -0600, Nathan Bossart wrote:
> That's my bad. +1 for fixing and back-patching.
Since it's my bug, I'll go ahead and apply the fix. I'll leave the new
test to you, though (unless you'd rather me take that, too).
--
nathan
On 2025-Nov-14, Andrew Dunstan wrote:
> OTOH, if you want to skip a lot of ok's in the regress_log file, you can do
> something like:
>
> fail("$line missing initial # in postgresql.conf.sample") if $line =~
> /^\s*[^#\s]/;
Yeah, I'm pretty confident we don't want one "ok" per correct line in
th
On 2025-11-14 Fr 9:06 AM, Daniel Gustafsson wrote:
When looking at the nearby suggestion to add deprecation comment for md5 in the
.conf.sample, I happened to notice that autovacuum_worker_slots isn't commented
out it the sample file.
AFAIK all GUCs in the sample file should be set to their def
On Fri, Nov 14, 2025 at 09:44:42AM -0500, Tom Lane wrote:
> Daniel Gustafsson writes:
>> When looking at the nearby suggestion to add deprecation comment for md5 in
>> the
>> .conf.sample, I happened to notice that autovacuum_worker_slots isn't
>> commented
>> out it the sample file.
>
>> AFAIK
On Fri, Nov 14, 2025 at 09:44:42AM -0500, Tom Lane wrote:
> Daniel Gustafsson writes:
> > When looking at the nearby suggestion to add deprecation comment for md5 in
> > the
> > .conf.sample, I happened to notice that autovacuum_worker_slots isn't
> > commented
> > out it the sample file.
>
> >
Daniel Gustafsson writes:
> When looking at the nearby suggestion to add deprecation comment for md5 in
> the
> .conf.sample, I happened to notice that autovacuum_worker_slots isn't
> commented
> out it the sample file.
> AFAIK all GUCs in the sample file should be set to their defaults and lef
