Re: Update outdated references to SLRU ControlLock

2025-09-02 Thread Julien Rouhaud
On Wed, Sep 03, 2025 at 10:21:54AM +0900, Michael Paquier wrote: > On Mon, Sep 01, 2025 at 01:19:41PM +0800, Julien Rouhaud wrote: > > I don't really have a preference. Bank lock is shorter but may be a bit > > more > > obscure, especially outside slru.c, so using "SLRU bank lock" could be > > b

Re: Update outdated references to SLRU ControlLock

2025-09-02 Thread Michael Paquier
On Mon, Sep 01, 2025 at 01:19:41PM +0800, Julien Rouhaud wrote: > I don't really have a preference. Bank lock is shorter but may be a bit more > obscure, especially outside slru.c, so using "SLRU bank lock" could be better > indeed. Okay, I have used "SLRU bank lock" and backpatched that down to

Re: Update outdated references to SLRU ControlLock

2025-08-31 Thread Julien Rouhaud
On Mon, Sep 01, 2025 at 02:05:56PM +0900, Michael Paquier wrote: > On Mon, Sep 01, 2025 at 11:32:41AM +0800, Julien Rouhaud wrote: > > Note that the main comment of slru.c still has one paragraph that mentions > > "bank control lock" consistently before switching to just "control lock" in > > the

Re: Update outdated references to SLRU ControlLock

2025-08-31 Thread Michael Paquier
On Mon, Sep 01, 2025 at 11:32:41AM +0800, Julien Rouhaud wrote: > Note that the main comment of slru.c still has one paragraph that mentions > "bank control lock" consistently before switching to just "control lock" in > the > next paragraph. I'm assuming that it's ok in that context as it seems