Re: Use pgstat_progress_update_multi_param instead of single param update

2021-02-21 Thread Michael Paquier
On Sun, Feb 21, 2021 at 04:43:23PM +0530, Bharath Rupireddy wrote: > While we are at it, I wanted to use a single line statement instead of > if else, just like we do it in do_analyze_rel as below. > > pgstat_progress_update_param(PROGRESS_ANALYZE_PHASE, > inh

Re: Use pgstat_progress_update_multi_param instead of single param update

2021-02-21 Thread Bharath Rupireddy
On Sun, Feb 21, 2021 at 4:18 PM Michael Paquier wrote: > > On Sun, Feb 21, 2021 at 11:30:21AM +0530, Bharath Rupireddy wrote: > > Attached is a patch that replaces some subsequent multiple > > update_param calls with a single update_multi_param. > > Looks mostly fine to me. > > -if (OidIsValid

Re: Use pgstat_progress_update_multi_param instead of single param update

2021-02-21 Thread Michael Paquier
On Sun, Feb 21, 2021 at 11:30:21AM +0530, Bharath Rupireddy wrote: > Attached is a patch that replaces some subsequent multiple > update_param calls with a single update_multi_param. Looks mostly fine to me. -if (OidIsValid(indexOid)) -pgstat_progress_update_param(PROGRESS_CLUSTER_COM