I wrote:
> The main thing that is bothering me about the remainder is its desire
> to offer single-punctuation-character completions such as "(". I do
> not see the point of that. You can't select a completion without
> typing at least one character, so what does it accomplish to offer
> those
Arthur Zakirov writes:
> On Sun, Jul 29, 2018 at 07:42:43PM -0500, Justin Pryzby wrote:
>>> Actually..another thought: since toast tables may be VACUUM-ed, should I
>>> introduce Query_for_list_of_tpmt ?
>> I didn't include this one yet though.
> I think it could be done by a separate patch.
I
On Sun, Jul 29, 2018 at 07:42:43PM -0500, Justin Pryzby wrote:
> Your suggestion is good, so attached updated patch.
The patch is in good shape. It compiles without errors. The patch
doesn't need in documentation.
I marked the patch as "Ready for Commiter".
> > > Actually..another thought:
Sorry for the delay..this got lost while catching up after being out of town..
On Thu, Jun 28, 2018 at 02:20:39PM +0300, Arthur Zakirov wrote:
> Thank you for the new version.
>
> On Wed, Jun 27, 2018 at 03:10:51PM -0500, Justin Pryzby wrote:
> > Thanks - I've done this in the attached. It
Thank you for the new version.
On Wed, Jun 27, 2018 at 03:10:51PM -0500, Justin Pryzby wrote:
> Thanks - I've done this in the attached. It works well for having minimal
> logic.
I think everthing is OK. But I didn't notice in previous version of the
patch that there is no braces in EXPLAIN and
On Mon, Jun 11, 2018 at 11:35:51PM +0300, Arthur Zakirov wrote:
> IMHO, I'd leave the code as simple as possible. It is up to you of
> course. But it is easy to add completion for a first attribute, by
> adding the condition (and leave other attributes without completion):
>
> else if
On Sat, Jun 09, 2018 at 06:42:12PM -0500, Justin Pryzby wrote:
> > Moreover there is no such completion for example for the command (it shows
> > only first column):
> >
> > CREATE INDEX ON test (
>
> Noted (I misunderstood at first: you just mean there's precedent that column
> names aren't
Thanks for review and comment.
On Tue, Jun 05, 2018 at 05:29:42PM +0300, Arthur Zakirov wrote:
> On Sun, Jun 03, 2018 at 10:39:22PM -0500, Justin Pryzby wrote:
> > > Also I think it could be good to list column names after parentheses,
> > > but I'm not sure if it easy to implement.
> > I tried
On Sun, Jun 03, 2018 at 10:39:22PM -0500, Justin Pryzby wrote:
> Find attached an update which also supports column completion using the legacy
> non-parenthesized syntax.
Thank you!
> BTW..should that be toast.tuple_target ??
I think shouldn't. From the documentation "This parameter cannot be
Find attached an update which also supports column completion using the legacy
non-parenthesized syntax.
diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index 7bb47ea..699a102 100644
--- a/src/bin/psql/tab-complete.c
+++ b/src/bin/psql/tab-complete.c
@@ -705,6 +705,7 @@
I finally got back to this; thanks everyone for reviews;
I also added completion for parenthesized explain (...)
d4382c4ae7ea1e272f4fee388aac8ff99421471a
and for ALTER TABLE SET (toast_tuple_target).
c2513365a0a85e77d3c21adb92fe12cfbe0d1897
BTW..should that be toast.tuple_target ??
Note that
On Tue, May 29, 2018 at 10:12:27AM -0400, Alvaro Herrera wrote:
> Is it just me that finds shocking the notion of vacuuming a foreign
> table?
I guess it would be nice to have the ability to tab complete that,
assuming it would actually do something at least potentially useful,
but until then,
Is it just me that finds shocking the notion of vacuuming a foreign
table?
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 29 May 2018 at 12:06, Justin Pryzby wrote:
> Find attached tab completion for the following:
>
> "... Also, recursively perform VACUUM and ANALYZE on partitions when the
> command is applied to a partitioned table."
> 3c3bb99330aa9b4c2f6258bfa0265d806bf365c3
>
> Add parenthesized options
Hello,
On Mon, May 28, 2018 at 07:06:23PM -0500, Justin Pryzby wrote:
> Find attached tab completion for the following:
The patch works well. I have a couple notes.
The patch replaces the variable Query_for_list_of_tmf by
Query_for_list_of_tpmf. So I think Query_for_list_of_tmf isn't needed
15 matches
Mail list logo
