Re: aio/README.md comments

2025-09-02 Thread Jeff Davis
On Sat, 2025-08-30 at 12:20 -0400, Andres Freund wrote: > There might be some regressions that make io_method=sync beneficial, > but short > to medium term, the goal ought to be to make all non-ridiculous > configurations > (I don't care about AIO performing well with s_b=16) to not regress > meani

Re: aio/README.md comments

2025-08-30 Thread Andres Freund
Hi, On 2025-08-29 15:23:48 -0700, Jeff Davis wrote: > On Fri, 2025-08-29 at 12:32 -0400, Andres Freund wrote: > > I don't really see an advantage of sync in those cases either. > > It seems a bit early to say that it's just there for debugging. But > it's just in a README, so I won't argue the po

Re: aio/README.md comments

2025-08-29 Thread Xuneng Zhou
Hi, On Sat, Aug 30, 2025 at 6:24 AM Jeff Davis wrote: > > On Fri, 2025-08-29 at 12:32 -0400, Andres Freund wrote: > > I don't really see an advantage of sync in those cases either. > > It seems a bit early to say that it's just there for debugging. But > it's just in a README, so I won't argue th

Re: aio/README.md comments

2025-08-29 Thread Jeff Davis
On Fri, 2025-08-29 at 12:32 -0400, Andres Freund wrote: > I don't really see an advantage of sync in those cases either. It seems a bit early to say that it's just there for debugging. But it's just in a README, so I won't argue the point. I attached some proposed changes based on my understandin

Re: aio/README.md comments

2025-08-29 Thread Andres Freund
Hi, On 2025-08-29 08:12:36 -0700, Jeff Davis wrote: > aio/README.md: > > * In the section "### IO can be started in critical sections", the > first paragraph seems like it belongs in another section. It explains why we want to eventually want do WAL IO using AIO, which in turn requires AIO to be