Re: allow specifying action when standby encounters incompatible parameter settings

2022-07-25 Thread Nathan Bossart
On Mon, Jul 18, 2022 at 03:17:10PM -0700, Nathan Bossart wrote: > Given this feedback, I intend to mark the associated commitfest entry as > Withdrawn at the conclusion of the current commitfest. Done. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com

Re: allow specifying action when standby encounters incompatible parameter settings

2022-07-18 Thread Nathan Bossart
On Fri, Jun 24, 2022 at 11:42:29AM +0100, Simon Riggs wrote: > This patch would undo a very important change - to keep servers > available by default and go back to the old behavior for a huge fleet > of Postgres databases. The old behavior of shutdown-on-change caused > catastrophe many times for

Re: allow specifying action when standby encounters incompatible parameter settings

2022-06-24 Thread Simon Riggs
On Thu, 23 Jun 2022 at 18:45, Nathan Bossart wrote: > > Thanks for chiming in. > > On Thu, Jun 23, 2022 at 04:19:45PM +0100, Simon Riggs wrote: > > I don't understand why you need this patch at all. > > > > Since you have automation, you can use that layer to automatically > > restart all standbys

Re: allow specifying action when standby encounters incompatible parameter settings

2022-06-23 Thread Nathan Bossart
Thanks for chiming in. On Thu, Jun 23, 2022 at 04:19:45PM +0100, Simon Riggs wrote: > I don't understand why you need this patch at all. > > Since you have automation, you can use that layer to automatically > restart all standbys at once, if you choose, without any help or > hindrance from Postg

Re: allow specifying action when standby encounters incompatible parameter settings

2022-06-23 Thread Simon Riggs
On Wed, 13 Apr 2022 at 22:35, Nathan Bossart wrote: > As of 15251c0, when a standby encounters an incompatible parameter change, > it pauses replay so that read traffic can continue while the administrator > fixes the parameters. Once the server is restarted, replay can continue. > Before this c

Re: allow specifying action when standby encounters incompatible parameter settings

2022-05-02 Thread Nathan Bossart
On Fri, Apr 29, 2022 at 06:35:52PM +, Cary Huang wrote: > The patch applied and tested fine. I think for this kind of exception, it > really is up to the administrator how he/she should proceed to resolve > depending on his/her business application. Leaving things configurable by the > user

Re: allow specifying action when standby encounters incompatible parameter settings

2022-04-29 Thread Cary Huang
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed Hello The patch applied and tested fine. I think for this ki

Re: allow specifying action when standby encounters incompatible parameter settings

2022-04-14 Thread Nathan Bossart
Thanks for taking a look! On Thu, Apr 14, 2022 at 11:36:11AM +0900, Kyotaro Horiguchi wrote: > At Wed, 13 Apr 2022 14:35:21 -0700, Nathan Bossart > wrote in >> I initially set out to see if it was possible to automatically adjust these >> parameters on a standby, but that is considerably more d

Re: allow specifying action when standby encounters incompatible parameter settings

2022-04-13 Thread Kyotaro Horiguchi
At Wed, 13 Apr 2022 14:35:21 -0700, Nathan Bossart wrote in > Hi hackers, > > As of 15251c0, when a standby encounters an incompatible parameter change, > it pauses replay so that read traffic can continue while the administrator > fixes the parameters. Once the server is restarted, replay can