Re: compiling pg_bsd_indent

2025-10-18 Thread Álvaro Herrera
On 2025-Oct-09, Bruce Momjian wrote: > Might be nice if we could just remove it. It was created by Tom Lane in > 2017. I think it would be a bad idea to lose the history there, so -1 on that from me. In particular, older branches (12 and back) require a version of pg_bsd_indent that would no lo

Re: compiling pg_bsd_indent

2025-10-18 Thread Tom Lane
Robert Haas writes: > No, I'm wrong about that, too. I don't seem to see it installing by > default, but maybe I am also wrong about that. No, we don't install it at all. If you choose, you can manually copy it to someplace in your $PATH. regards, tom lane

Re: compiling pg_bsd_indent

2025-10-18 Thread Bruce Momjian
On Thu, Oct 9, 2025 at 06:12:59PM +0200, Álvaro Herrera wrote: > On 2025-Oct-09, Bruce Momjian wrote: > > > Might be nice if we could just remove it. It was created by Tom Lane in > > 2017. > > I think it would be a bad idea to lose the history there, so -1 on that > from me. In particular, ol

Re: compiling pg_bsd_indent

2025-10-18 Thread Nathan Bossart
On Thu, Oct 09, 2025 at 11:49:31AM -0400, Andres Freund wrote: > On 2025-10-09 11:43:57 -0400, Robert Haas wrote: >> While $SUBJECT today -- using the sources from >> https://git.postgresql.org/git/pg_bsd_indent.git -- I ran into some >> problems. I got errors due to the replacement of >> pg_attrib

Re: compiling pg_bsd_indent

2025-10-17 Thread Robert Haas
On Thu, Oct 9, 2025 at 11:51 AM Robert Haas wrote: > On Thu, Oct 9, 2025 at 11:49 AM Andres Freund wrote: > > I thought we basically only used the in-tree pg_bsd_indent these days? > > Oh, I missed the fact that we'd moved it into the tree. But it looks > like you can't build it with meson? No,

Re: compiling pg_bsd_indent

2025-10-17 Thread Andres Freund
Hi, On 2025-10-09 11:43:57 -0400, Robert Haas wrote: > While $SUBJECT today -- using the sources from > https://git.postgresql.org/git/pg_bsd_indent.git -- I ran into some > problems. I got errors due to the replacement of > pg_attribute_noreturn() with pg_return(), and warnings due to variable >

Re: compiling pg_bsd_indent

2025-10-17 Thread Tom Lane
Robert Haas writes: > While $SUBJECT today -- using the sources from > https://git.postgresql.org/git/pg_bsd_indent.git -- I ran into some > problems. I got errors due to the replacement of > pg_attribute_noreturn() with pg_return(), and warnings due to variable > definitions with no previous exte

Re: compiling pg_bsd_indent

2025-10-17 Thread Robert Haas
On Thu, Oct 9, 2025 at 11:49 AM Andres Freund wrote: > I thought we basically only used the in-tree pg_bsd_indent these days? Oh, I missed the fact that we'd moved it into the tree. But it looks like you can't build it with meson? -- Robert Haas EDB: http://www.enterprisedb.com

Re: compiling pg_bsd_indent

2025-10-09 Thread Bruce Momjian
On Thu, Oct 9, 2025 at 11:49:31AM -0400, Andres Freund wrote: > Hi, > > On 2025-10-09 11:43:57 -0400, Robert Haas wrote: > > While $SUBJECT today -- using the sources from > > https://git.postgresql.org/git/pg_bsd_indent.git -- I ran into some > > problems. I got errors due to the replacement of

Re: compiling pg_bsd_indent

2025-10-09 Thread Andres Freund
On 2025-10-09 11:51:15 -0400, Robert Haas wrote: > On Thu, Oct 9, 2025 at 11:49 AM Andres Freund wrote: > > I thought we basically only used the in-tree pg_bsd_indent these days? > > Oh, I missed the fact that we'd moved it into the tree. But it looks > like you can't build it with meson? It can