Re: cpluspluscheck vs ICU again

2025-07-07 Thread Tom Lane
John Naylor writes: > I see that now. If extensions follow the practice of including system > headers before Postgres headers, it should be fine. I've attached v2 > which removes the useless #undef and drafts an explanatory commit > message. Works for me. regards, tom lan

Re: cpluspluscheck vs ICU again

2025-07-06 Thread John Naylor
On Fri, Jul 4, 2025 at 10:11 PM Tom Lane wrote: > > Andres Freund writes: > >> +/* restore so that extensions can include the C++ APIs */ > >> +#undef U_SHOW_CPLUSPLUS_API > > > Does the #undef U_SHOW_CPLUSPLUS_API thing actually work, given that ucol.h > > presumably won't be included again due

Re: cpluspluscheck vs ICU again

2025-07-04 Thread Tom Lane
Andres Freund writes: > On 2025-07-02 14:01:13 +0700, John Naylor wrote: >> I came up with the attached -- Andres, Peter, does this match your >> recollection? > I think the proper fix here would be to not expose ucol.h to the world, > i.e. not include it from something like pg_locale.h. The st

Re: cpluspluscheck vs ICU again

2025-07-04 Thread Andres Freund
Hi, On 2025-07-02 14:01:13 +0700, John Naylor wrote: > On Tue, Jul 1, 2025 at 9:24 PM Tom Lane wrote: > > Ha, indeed you are right. On my RHEL9 box, it's kinda drowned out > > by complaints about > > > > /usr/include/c++/11/bits/range_access.h:109:3: error: template with C > > linkage > > 109

Re: cpluspluscheck vs ICU again

2025-07-02 Thread Tom Lane
John Naylor writes: > After pushing my fix, I looked into this, and CI works around this by > disabling ICU. A proper fix was discussed here, but it trailed off: > https://www.postgresql.org/message-id/flat/20230311033727.koa4saxy5wyquu6s%40awork3.anarazel.de#03346c63050bbc69dfca8981a5698e4a > I c

Re: cpluspluscheck vs ICU again

2025-07-02 Thread Peter Eisentraut
On 02.07.25 09:01, John Naylor wrote: On Tue, Jul 1, 2025 at 9:24 PM Tom Lane wrote: Ha, indeed you are right. On my RHEL9 box, it's kinda drowned out by complaints about /usr/include/c++/11/bits/range_access.h:109:3: error: template with C linkage 109 | template _Tp* end(valarray<_Tp>&)

Re: cpluspluscheck vs ICU

2023-08-08 Thread Peter Eisentraut
On 08.08.23 01:35, Andres Freund wrote: Hi, On 2023-03-10 20:10:30 -0800, Andres Freund wrote: On 2023-03-10 19:37:27 -0800, Andres Freund wrote: I just hit this once more - and I figured out a fairly easy fix: We just need a #ifndef U_DEFAULT_SHOW_DRAFT #define U_DEFAULT_SHOW_DRAFT 0

Re: cpluspluscheck vs ICU

2023-08-07 Thread Andres Freund
Hi, On 2023-03-10 20:10:30 -0800, Andres Freund wrote: > On 2023-03-10 19:37:27 -0800, Andres Freund wrote: > > I just hit this once more - and I figured out a fairly easy fix: > > > > We just need a > > #ifndef U_DEFAULT_SHOW_DRAFT > > #define U_DEFAULT_SHOW_DRAFT 0 > > #endif > > before i

Re: cpluspluscheck vs ICU

2023-03-10 Thread Andres Freund
Hi, On 2023-03-10 19:37:27 -0800, Andres Freund wrote: > On 2022-03-23 08:56:17 -0700, Andres Freund wrote: > > On 2022-03-23 08:19:38 -0400, Andrew Dunstan wrote: > > > On 3/22/22 22:23, Andres Freund wrote: > > > That only helps when running the CI/cfbot setup. Fixing it for other > > > (manual

Re: cpluspluscheck vs ICU

2023-03-10 Thread Andres Freund
Hi, On 2022-03-23 08:56:17 -0700, Andres Freund wrote: > On 2022-03-23 08:19:38 -0400, Andrew Dunstan wrote: > > On 3/22/22 22:23, Andres Freund wrote: > > That only helps when running the CI/cfbot setup. Fixing it for other > > (manual or buildfarm) users would be nice. Luckily crake isn't buildi

Re: cpluspluscheck vs ICU

2022-03-23 Thread Andres Freund
Hi, On 2022-03-23 08:19:38 -0400, Andrew Dunstan wrote: > On 3/22/22 22:23, Andres Freund wrote: > > On 2022-03-22 17:20:24 -0700, Andres Freund wrote: > >> I was about to propose adding headerscheck / cpluspluscheck to the CI file > >> so > >> that cfbot can catch future issues. > > The attached

Re: cpluspluscheck vs ICU

2022-03-23 Thread Andrew Dunstan
On 3/22/22 22:23, Andres Freund wrote: > Hi, > > On 2022-03-22 17:20:24 -0700, Andres Freund wrote: >> I was about to propose adding headerscheck / cpluspluscheck to the CI file so >> that cfbot can catch future issues. > The attached patch does so, with ICU disabled to avoid the problems discuss

Re: cpluspluscheck vs ICU

2022-03-22 Thread Thomas Munro
On Wed, Mar 23, 2022 at 3:23 PM Andres Freund wrote: > On 2022-03-22 17:20:24 -0700, Andres Freund wrote: > > I was about to propose adding headerscheck / cpluspluscheck to the CI file > > so > > that cfbot can catch future issues. > > The attached patch does so, with ICU disabled to avoid the pr

Re: cpluspluscheck vs ICU

2022-03-22 Thread Andres Freund
Hi, On 2022-03-22 17:20:24 -0700, Andres Freund wrote: > I was about to propose adding headerscheck / cpluspluscheck to the CI file so > that cfbot can catch future issues. The attached patch does so, with ICU disabled to avoid the problems discussed in the thread. Example run: https://cirrus-ci.