Re: defGetBoolean - Fix comment

2022-07-10 Thread Peter Smith
On Mon, Jul 11, 2022 at 12:09 PM Michael Paquier wrote: > > On Thu, Jul 07, 2022 at 09:54:24AM +0900, Michael Paquier wrote: > > Still, I think that your adjustment is right, as the check is, indeed, > > on the DefElem's value*. Or you could just say "If no value given". > > Peter, I have applied

Re: defGetBoolean - Fix comment

2022-07-10 Thread Michael Paquier
On Thu, Jul 07, 2022 at 09:54:24AM +0900, Michael Paquier wrote: > Still, I think that your adjustment is right, as the check is, indeed, > on the DefElem's value*. Or you could just say "If no value given". Peter, I have applied something using your original wording. This is a minor issue, but

Re: defGetBoolean - Fix comment

2022-07-06 Thread Michael Paquier
On Thu, Jul 07, 2022 at 09:53:01AM +1000, Peter Smith wrote: > Really this code is for the case when there *was* a parameter given > (e.g. "copy_data" in my example above) but when there is no parameter > *value* given. > > Suggested comment fix: > BEFORE > If no parameter given, assume "true" is