Re: foreign key on virtual generated column

2025-11-04 Thread Srinath Reddy Sadipiralla
Hi Jian, did initial testing and review ,the patches LGTM except indentation we can solve this by running pg_indent. i have one doubt that why we are using compute_virtual argument todo the same work in both cases, is it because of future proofing ,like we may do something different for stored an

Re: foreign key on virtual generated column

2025-10-17 Thread Srinath Reddy Sadipiralla
Hi Jian , Thanks for working on this , I started reviewing these patches , just need a very small rebase to v1-0002 because a recent commit(cc2ac0e) removed catalog/pg_proc.h header from ri_triggers.c . -- Thanks, Srinath Reddy Sadipiralla EDB: https://www.enterprisedb.com/