Re: pg_plan_advice

2025-11-17 Thread Robert Haas
On Mon, Nov 17, 2025 at 9:42 AM Matheus Alcantara wrote: > I've spent some time playing with these patches. I still don't have to > much comments on the syntax yet but I've noticed a small bug or perhaps > I'm missing something? Cool, thanks for looking. I am guessing that the paucity of feedback

Re: pg_plan_advice

2025-11-17 Thread Matheus Alcantara
Hi On Thu Nov 6, 2025 at 1:45 PM -03, Robert Haas wrote: > Here's v3. I've attempted to fix some more things that cfbot didn't > like, one of which was an actual bug in 0005, and I also fixed a > stupid few bugs in pgpa_collector.c and added a few more tests. > I've spent some time playing with th

Re: pg_plan_advice

2025-11-04 Thread John Naylor
On Thu, Oct 30, 2025 at 9:00 PM Robert Haas wrote: > First, any form of user control over the > planner tends to be a lightning rod for criticism around here. I've > come to believe that's the wrong way of thinking about it: we can want > to improve the planner over the long term and *also* want t

Re: pg_plan_advice

2025-11-03 Thread Robert Haas
On Sat, Nov 1, 2025 at 12:10 PM Hannu Krosing wrote: > This reinforces my belief thet we either should have some kind of > two-level optimization, where most queries are handled quickly but > with something to trigger a more elaborate optimisation and > investigation workflow. > > Or alternatively

Re: pg_plan_advice

2025-11-03 Thread Robert Haas
On Fri, Oct 31, 2025 at 5:17 PM Alastair Turner wrote: > I really like the functionality of the current patch as well, even though I > am suspicious of user control over the planner. By giving concise, precise > control over a plan, this allows people who believe they can out-plan the > planner

Re: pg_plan_advice

2025-11-01 Thread Hannu Krosing
This weas recently shared in LinkedIn https://www.vldb.org/pvldb/vol18/p5126-bress.pdf For example it says that 31% of all queries are metadata queries, 78% have LIMIT, 20% of queries have 10+ joins, with 0.52% exceeding 100 joins. , 12% of expressions have depths between 11-100 levels, some excee

Re: pg_plan_advice

2025-10-31 Thread Alastair Turner
On Fri, 31 Oct 2025, 12:51 Robert Haas, wrote: > On Fri, Oct 31, 2025 at 5:59 AM Jakub Wartak > wrote: > > > First, any form of user control over the planner tends to be a > lightning rod for criticism around here. > > > > I do not know where this is coming from, but everybody I've talked to > >

Re: pg_plan_advice

2025-10-31 Thread Robert Haas
On Fri, Oct 31, 2025 at 5:59 AM Jakub Wartak wrote: > > First, any form of user control over the planner tends to be a lightning > > rod for criticism around here. > > I do not know where this is coming from, but everybody I've talked to > was saying this is needed to handle real enterprise datab

Re: pg_plan_advice

2025-10-31 Thread Jakub Wartak
On Thu, Oct 30, 2025 at 3:00 PM Robert Haas wrote: [..over 400kB of attachments, yay] Thank You for working on this! My gcc-13 was nitpicking a little bit (see compilation_warnings_v1.txt), so attached is just a tiny diff to fix some of those issues. After that, clang-20 run was clean too. > F