Re: pg_restore --no-policies should not restore policies' comment

2025-07-03 Thread jian he
On Wed, Jul 2, 2025 at 5:18 PM Fujii Masao wrote: > > > hi. > > > > I’ve tested the pg_restore options --no-policies, --no-publications, and > > --no-subscriptions locally. > > Thanks for updating the patch! Could you add it to the next CommitFest > so we don't forget about it? > sure. > > > Howe

Re: pg_restore --no-policies should not restore policies' comment

2025-07-02 Thread Fujii Masao
On 2025/07/02 11:17, jian he wrote: On Fri, Jun 27, 2025 at 1:34 PM Fujii Masao wrote: To do that, we need 1. we checked that COMMENTS on policies, the TocEntry->tag begins with "POLICY". which is true, see above code walk through. 2. We also need to make sure that no other dumpComment cal

Re: pg_restore --no-policies should not restore policies' comment

2025-07-01 Thread jian he
On Fri, Jun 27, 2025 at 1:34 PM Fujii Masao wrote: > > > To do that, we need > > 1. we checked that COMMENTS on policies, the TocEntry->tag begins with > > "POLICY". which is true, see above code walk through. > > 2. We also need to make sure that no other dumpComment call results in a > > COMMENT

Re: pg_restore --no-policies should not restore policies' comment

2025-06-26 Thread Fujii Masao
On 2025/06/27 13:08, jian he wrote: hi. first looking at function dumpPolicy (pg_dump.c): appendPQExpBuffer(polprefix, "POLICY %s ON", fmtId(polinfo->polname)); tag = psprintf("%s %s", tbinfo->dobj.name, polinfo->dobj.name); if (polinfo->dobj.dum