Re: pg_restore - cannot to restore blobs in dictionary format from older pg dumps

2025-06-08 Thread Pavel Stehule
ne 8. 6. 2025 v 23:09 odesílatel Tom Lane napsal: > I wrote: > > I think your patch is about the right thing to do, although I'm > > inclined to check for K_VERS_1_14 which is closer to when the > > fix was made. > > Pushed. After thinking about how to rewrite the comment, I went > with the vers

Re: pg_restore - cannot to restore blobs in dictionary format from older pg dumps

2025-06-08 Thread Tom Lane
I wrote: > I think your patch is about the right thing to do, although I'm > inclined to check for K_VERS_1_14 which is closer to when the > fix was made. Pushed. After thinking about how to rewrite the comment, I went with the version test as you had it. K_VERS_1_14 isn't really better, since i

Re: pg_restore - cannot to restore blobs in dictionary format from older pg dumps

2025-06-08 Thread Tom Lane
Pavel Stehule writes: > It is a problem of PostgreSQL 11 - the pg_dump from PostgreSQL 12 sets > filename correctly, > and pg_restore doesn't need patching (in this case). Yeah. It looks like the actual filename was always "blobs.toc" before v17, but prior to 548e50976 pg_backup_directory.c's _A

Re: pg_restore - cannot to restore blobs in dictionary format from older pg dumps

2025-06-08 Thread Pavel Stehule
Hi > The problem is related to the commit a45c78e > > I am not sure if this is correct fix, but it fixed this issue > > diff --git a/src/bin/pg_dump/pg_backup_directory.c > b/src/bin/pg_dump/pg_backup_directory.c > index 21b00792a8a..16da4decbd0 100644 > --- a/src/bin/pg_dump/pg_backup_directory

Re: pg_restore - cannot to restore blobs in dictionary format from older pg dumps

2025-06-08 Thread Pavel Stehule
Hi ne 8. 6. 2025 v 14:39 odesílatel Pavel Stehule napsal: > Hi, > > one customer reported an issue related probably to pg_restore and > dictionary format. > > Inside PostgreSQL 11 I created one large object > > I used pg_dump (version 11) and did dump a) dictionary format, b) tar > format > > I