Re: pg_upgrade test chatter

2021-10-19 Thread Alvaro Herrera
On 2021-Oct-19, Tom Lane wrote: > Yeah, my original thought had been to hack this at the test level. > However, I felt like it'd be worth adding this code because we could > apply it elsewhere in pg_regress.c to save several psql sessions > (and hence backend starts) per regression DB creation. T

Re: pg_upgrade test chatter

2021-10-19 Thread Tom Lane
Alvaro Herrera writes: > On 2021-Oct-19, Tom Lane wrote: >> We could dodge that, with modern versions of psql, by issuing >> two -c switches. > Isn't it easier to pass client_min_messages via PGOPTIONS? > PGOPTIONS="-c client_min_messages=warning" psql -c "drop database if exists > foo" Yeah,

Re: pg_upgrade test chatter

2021-10-19 Thread Alvaro Herrera
On 2021-Oct-19, Tom Lane wrote: > I tried doing this as a one-liner change in pg_regress's > drop_database_if_exists(), but the idea fell over pretty > quickly, because what underlies that is a "psql -c" call: > > $ psql -c 'set client_min_messages = warning; drop database if exists foo' > ERROR:

Re: pg_upgrade test chatter

2021-10-19 Thread Bossart, Nathan
On 10/19/21, 12:37 PM, "Tom Lane" wrote: > Actually ... why shouldn't we suppress that by running the command > with client_min_messages = warning? This would have to be a change > to pg_regress, but I'm having a hard time thinking of cases where > quieting that message would be a problem. I was

Re: pg_upgrade test chatter

2021-10-19 Thread Tom Lane
I wrote: > "Bossart, Nathan" writes: >> I run 'make check-world' a lot, and I typically use parallelism and >> redirect stdout to /dev/null as suggested in the docs [0]. This seems >> to eliminate all of the test chatter except for this one message: >> NOTICE: database "regression" does not exis

Re: pg_upgrade test chatter

2021-10-19 Thread Tom Lane
"Bossart, Nathan" writes: > I run 'make check-world' a lot, and I typically use parallelism and > redirect stdout to /dev/null as suggested in the docs [0]. This seems > to eliminate all of the test chatter except for this one message: > NOTICE: database "regression" does not exist, ski