On Wed, 30 Aug 2023 10:11:10 +0900 (JST)
Tatsuo Ishii wrote:
> Yugo,
> Fabien,
>
> >>> I start to think this behavior is ok and consistent with previous
> >>> behavior of pgbench because serialization (and dealock) errors have
> >>> been treated specially from other types of errors, such as
Yugo,
Fabien,
>>> I start to think this behavior is ok and consistent with previous
>>> behavior of pgbench because serialization (and dealock) errors have
>>> been treated specially from other types of errors, such as accessing
>>> non existing tables. However, I suggest to add more sentences to
On Thu, 24 Aug 2023 09:15:51 +0900 (JST)
Tatsuo Ishii wrote:
> >> I start to think this behavior is ok and consistent with previous
> >> behavior of pgbench because serialization (and dealock) errors have
> >> been treated specially from other types of errors, such as accessing
> >> non existing
>> I start to think this behavior is ok and consistent with previous
>> behavior of pgbench because serialization (and dealock) errors have
>> been treated specially from other types of errors, such as accessing
>> non existing tables. However, I suggest to add more sentences to the
>> explanation
On Sat, 19 Aug 2023 19:51:56 +0900 (JST)
Tatsuo Ishii wrote:
> > I have tested the v4 patch with default_transaction_isolation =
> > 'repeatable read'.
> >
> > pgbench --exit-on-abort -N -p 11002 -c 10 -T 30 test
> > pgbench (17devel, server 15.3)
> > starting vacuum...end.
> > transaction
> I have tested the v4 patch with default_transaction_isolation =
> 'repeatable read'.
>
> pgbench --exit-on-abort -N -p 11002 -c 10 -T 30 test
> pgbench (17devel, server 15.3)
> starting vacuum...end.
> transaction type:
> scaling factor: 1
> query mode: simple
> number of clients: 10
> number
> About pgbench exit on abort v4:
>
> Patch applies cleanly, compiles, local make check ok, doc looks ok.
>
> This looks ok to me.
I have tested the v4 patch with default_transaction_isolation =
'repeatable read'.
pgbench --exit-on-abort -N -p 11002 -c 10 -T 30 test
pgbench (17devel, server
About pgbench exit on abort v4:
Patch applies cleanly, compiles, local make check ok, doc looks ok.
This looks ok to me.
--
Fabien.
On Sun, 13 Aug 2023 11:27:55 +0200 (CEST)
Fabien COELHO wrote:
>
> Hello Yugo-san,
>
> >> I attached the updated patch v3 including changes above, a test,
> >> and fix of the typo you pointed out.
> >
> > I'm sorry but the test in the previous patch was incorrect.
> > I attached the correct
Hello Yugo-san,
I attached the updated patch v3 including changes above, a test,
and fix of the typo you pointed out.
I'm sorry but the test in the previous patch was incorrect.
I attached the correct one.
About pgbench exit on abort v3:
Patch does not "git apply", but is ok with "patch"
On Wed, 9 Aug 2023 13:59:21 +0900
Yugo NAGATA wrote:
> On Wed, 9 Aug 2023 10:46:38 +0900
> Yugo NAGATA wrote:
>
> > On Wed, 9 Aug 2023 02:15:01 +0200 (CEST)
> > Fabien COELHO wrote:
> >
> > >
> > > Hello Yugo-san,
> > >
> > > > There are cases where "goto done" is used where some error
On Wed, 9 Aug 2023 10:46:38 +0900
Yugo NAGATA wrote:
> On Wed, 9 Aug 2023 02:15:01 +0200 (CEST)
> Fabien COELHO wrote:
>
> >
> > Hello Yugo-san,
> >
> > > There are cases where "goto done" is used where some error like
> > > "invalid socket: ..." happens. I would like to make pgbench exit in
On Wed, 9 Aug 2023 02:15:01 +0200 (CEST)
Fabien COELHO wrote:
>
> Hello Yugo-san,
>
> > There are cases where "goto done" is used where some error like
> > "invalid socket: ..." happens. I would like to make pgbench exit in
> > such cases, too, so I chose to handle errors below the "done:"
Hello Yugo-san,
There are cases where "goto done" is used where some error like
"invalid socket: ..." happens. I would like to make pgbench exit in
such cases, too, so I chose to handle errors below the "done:" label.
However, we can change it to call "exit" instead of "goo done" at each
Hello Fabien,
On Mon, 7 Aug 2023 12:17:38 +0200 (CEST)
Fabien COELHO wrote:
>
> Hello Yugo-san,
>
> > I attached v2 patch including the documentation and some comments
> > in the code.
>
> I've looked at this patch.
Thank you for your review!
>
> I'm unclear whether it does what it says:
Hello Yugo-san,
I attached v2 patch including the documentation and some comments
in the code.
I've looked at this patch.
I'm unclear whether it does what it says: "exit immediately on abort", I
would expect a cold call to "exit" (with a clear message obviously) when
the abort occurs.
On Mon, 7 Aug 2023 11:02:48 +0900
Yugo NAGATA wrote:
> On Sat, 05 Aug 2023 12:16:11 +0900 (JST)
> Tatsuo Ishii wrote:
>
> > > Hi,
> > >
> > > I would like to propose to add an option to pgbench so that benchmark
> > > can quit immediately when any client is aborted. Currently, when a
> > >
On Sat, 05 Aug 2023 12:16:11 +0900 (JST)
Tatsuo Ishii wrote:
> > Hi,
> >
> > I would like to propose to add an option to pgbench so that benchmark
> > can quit immediately when any client is aborted. Currently, when a
> > client is aborted due to some error, for example, network trouble,
> >
> Hi,
>
> I would like to propose to add an option to pgbench so that benchmark
> can quit immediately when any client is aborted. Currently, when a
> client is aborted due to some error, for example, network trouble,
> other clients continue their run until a certain number of transactions
>
19 matches
Mail list logo
