Re: pgcrypto: Remove explicit hex encoding/decoding from tests

2021-12-03 Thread Tom Lane
Peter Eisentraut writes: > pg_regress.c sets bytea_output to hex already. Ah, right. Nevermind that then. regards, tom lane

Re: pgcrypto: Remove explicit hex encoding/decoding from tests

2021-12-03 Thread Peter Eisentraut
On 02.12.21 19:30, Tom Lane wrote: Generally +1, but I see you removed some instances of --- ensure consistent test output regardless of the default bytea format -SET bytea_output TO escape; I think that the principle still applies that this should work regardless of the installation's default

Re: pgcrypto: Remove explicit hex encoding/decoding from tests

2021-12-02 Thread Tom Lane
Peter Eisentraut writes: > pgcrypto tests use encode() and decode() calls to convert to/from hex > encoding. This was from before the hex format was available in bytea. > Now we can remove the extra explicit encoding/decoding calls and rely on > the default output format. Generally +1, but I

Re: pgcrypto: Remove explicit hex encoding/decoding from tests

2021-12-02 Thread Daniel Gustafsson
> On 2 Dec 2021, at 10:22, Peter Eisentraut > wrote: > pgcrypto tests use encode() and decode() calls to convert to/from hex > encoding. This was from before the hex format was available in bytea. Now we > can remove the extra explicit encoding/decoding calls and rely on the default > output