On Fri, 28 Jan 2022 at 08:44, Robert Haas wrote:
> OK. I'm still surprised, but it is what it is. I've committed this now.
Thanks
> FWIW, I would have been fine with you just committing this change.
That's good to know, thanks for mentioning it. FWIW, I just held back
as I wasn't 100% sure on
On Tue, Jan 25, 2022 at 3:56 PM David Rowley wrote:
> On Wed, 26 Jan 2022 at 07:12, Robert Haas wrote:
> > wouldn't this same consideration apply to a very large number of other
> > places in the code base?
>
> All of the other places are handled. See locations with "keep compiler quiet".
>
> Thi
On Wed, 26 Jan 2022 at 07:12, Robert Haas wrote:
> wouldn't this same consideration apply to a very large number of other
> places in the code base?
All of the other places are handled. See locations with "keep compiler quiet".
This one is the only one that generates a warning:
basebackup_gzip.
On Tue, Jan 25, 2022 at 4:20 AM David Rowley wrote:
> On Tue, 25 Jan 2022 at 09:14, Robert Haas wrote:
> > src/backend/replication/basebackup_gzip.c | 309
> > ++
>
> This could do with the attached. MSVC compilers need a bit more
> reassurance that ereport/elog ERROR
