Erik Wienhold writes:
> On 2025-10-02 00:25 +0200, Tom Lane wrote:
>> I am not entirely sure that we should commit 0002 though; it may be
>> that the savings is down in the noise anyway once you consider all
>> the other work that happens while printing a big table.
> I see larger gains for queri
Erik Wienhold writes:
> On 2025-10-02 00:25 +0200, Tom Lane wrote:
>> I am not entirely sure that we should commit 0002 though; it may be
>> that the savings is down in the noise anyway once you consider all the
>> other work that happens while printing a big table. A positive reason
>> not to ta
Erik Wienhold writes:
> Here's v3 to address all of this. I split it into three separate
> patches:
Thanks! While reviewing this I decided that splitting it wasn't
such a great idea, because I kept getting distracted by obvious
bugs in the code you were copying around, only to realize that
the
On 2025-08-19 03:52 +0200, Erik Wienhold wrote:
> On 2025-08-17 17:19 +0200, Tom Lane wrote:
> > This appears to fix the problem it sets out to fix, but it looks
> > to me like there are adjacent problems of the same ilk; do you
> > feel like looking at those?
> >
> > Specifically, I wondered whet
On 2025-08-17 17:19 +0200, Tom Lane wrote:
> Erik Wienhold writes:
> > On 2025-08-11 20:28 +0200, Greg Sabino Mullane wrote:
> >> Patch looks good, applies and works. Needs a pgindent run:
>
> > Thanks for the review. Here's v2 with proper formatting.
>
> This appears to fix the problem it sets
Erik Wienhold writes:
> On 2025-08-11 20:28 +0200, Greg Sabino Mullane wrote:
>> Patch looks good, applies and works. Needs a pgindent run:
> Thanks for the review. Here's v2 with proper formatting.
This appears to fix the problem it sets out to fix, but it looks
to me like there are adjacent p
On 2025-08-11 20:28 +0200, Greg Sabino Mullane wrote:
> Patch looks good, applies and works. Needs a pgindent run:
Thanks for the review. Here's v2 with proper formatting.
--
Erik
>From 96479e8bcc2d6598ce7d76ff7282541dc4d2e58e Mon Sep 17 00:00:00 2001
From: Erik Wienhold
Date: Wed, 7 May 2025
Patch looks good, applies and works. Needs a pgindent run:
- for (f = cont->footers; f; f = f->next) {
- int f_lines;
+ for (f = cont->footers; f; f = f->next)
+ {
+ int