On Wed, Mar 28, 2018 at 12:07 AM, Amit Langote
wrote:
> On 2018/03/22 11:45, Amit Langote wrote:
>> FWIW, I did manage to rebase it this morning and posting it here.
>
> Rebased again.
>
> I started wondering if we should separate out stuff related to partition
> bounds. That is create a utils/pa
Robert Haas wrote:
> On Wed, Mar 21, 2018 at 10:20 AM, Alvaro Herrera
> wrote:
> > Let's keep this entry open till the last minute.
>
> Ugh, I don't like keeping things open till the last minute all that
> much, especially if they're not being updated. But since this has
> been updated I guess i
On Wed, Mar 21, 2018 at 10:20 AM, Alvaro Herrera
wrote:
> Let's keep this entry open till the last minute.
Ugh, I don't like keeping things open till the last minute all that
much, especially if they're not being updated. But since this has
been updated I guess it's somewhat moot.
Are you going
Alvaro Herrera writes:
> David Steele wrote:
>> Are you planning to update this patch? If not, I think it should be
>> marked as Returned with Feedback and submitted to the next CF once it
>> has been updated.
> This is no new development, only code movement. I think it would be
> worse to have
David Steele wrote:
> > Sorry about the confusing comment. It could be sometime later half of
> > the next week.
>
> We are now three weeks into the CF with no new patch.
>
> Are you planning to update this patch? If not, I think it should be
> marked as Returned with Feedback and submitted to
Hi Amit,
On 3/2/18 11:17 AM, Amit Langote wrote:
>
> On Fri, Mar 2, 2018 at 11:53 PM, David Steele wrote:
>> Hi Amit,
>>
>> On 2/16/18 3:36 AM, Amit Langote wrote:
>>>
>>> Attached updated version.
>>
>> This patch no longer applies and the conflicts do not appear to be trivial.
>>
>> I'm a bit
Hi David.
On Fri, Mar 2, 2018 at 11:53 PM, David Steele wrote:
> Hi Amit,
>
> On 2/16/18 3:36 AM, Amit Langote wrote:
>>
>> Attached updated version.
>
> This patch no longer applies and the conflicts do not appear to be trivial.
>
> I'm a bit confused about your comment in [1]:
>
>> I gave up on
Hi Amit,
On 2/16/18 3:36 AM, Amit Langote wrote:
>
> Attached updated version.
This patch no longer applies and the conflicts do not appear to be trivial.
I'm a bit confused about your comment in [1]:
> I gave up on rebasing this patch yesterday as I couldn't finish it in
> 5 minutes, but mayb
Hello. I'd like to make a humble comment.
At Thu, 15 Feb 2018 19:31:47 +0900, Amit Langote
wrote in
<8906c861-ea47-caee-c860-eff8d7e1d...@lab.ntt.co.jp>
> Added to CF here: https://commitfest.postgresql.org/17/1520/
The reorganization adds/removes header files to/from .[ch]
files. That can eas
Added to CF here: https://commitfest.postgresql.org/17/1520/
Thanks,
Amit
On 2018/02/15 5:30, Alvaro Herrera wrote:
> BTW may I suggest that
>
> git config diff.algorithm=histogram
>
> results in better diffs?
Aha! That's much better.
Thanks,
Amit
BTW may I suggest that
git config diff.algorithm=histogram
results in better diffs?
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
This is looking attractive.
Please don't #include postgres.h in partcache.h. That's per policy.
Why do you need to #include parsenodes.h in partcache.h?
I think rewriteManip.h can do with just relcache.h rather than rel.h
(probably partition.h can do likewise)
thanks
--
Álvaro Herrera
On 2018/02/13 23:08, Ashutosh Bapat wrote:
> On Tue, Feb 13, 2018 at 2:17 PM, Amit Langote
> wrote:
>>
>> Agree with the proposed reorganizing and adding a partcache.c, which I
>> tried to do in the attached patch.
>>
>> * The new src/backend/utils/cache/partcache.c contains functions that
>> init
On 2018/02/13 22:23, Alvaro Herrera wrote:
> Thanks for working on this. May I suggest to open a completely new
> thread?
Done.
Thanks,
Amit
On Tue, Feb 13, 2018 at 2:17 PM, Amit Langote
wrote:
>
> Agree with the proposed reorganizing and adding a partcache.c, which I
> tried to do in the attached patch.
>
> * The new src/backend/utils/cache/partcache.c contains functions that
> initialize relcache's partitioning related fields. Vario
Thanks for working on this. May I suggest to open a completely new
thread?
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
17 matches
Mail list logo
