Hi,
On 2022-03-23 10:42:03 -0700, Andres Freund wrote:
> On 2022-03-23 17:27:50 +0900, Kyotaro Horiguchi wrote:
> > + /*
> > +* When starting with crash recovery, reset pgstat data - it might not
> > be
> > +* valid. Otherwise restore pgstat data. It's safe to do this here,
> > +* b
Hi,
On 2022-03-23 16:38:33 +0900, Kyotaro Horiguchi wrote:
> At Tue, 22 Mar 2022 11:56:40 +0900 (JST), Kyotaro Horiguchi
> wrote in
> > Docs.. Yeah I'll try it.
>
> This is the first cut, based on the earlier patchset.
Thanks!
> I didn't mention pgstat_force_next_flush() since I think it i
(nice work about ubsan)
At Wed, 23 Mar 2022 10:42:03 -0700, Andres Freund wrote in
> Hi,
>
> On 2022-03-23 17:27:50 +0900, Kyotaro Horiguchi wrote:
> > At Mon, 21 Mar 2022 14:30:17 -0700, Andres Freund
> > wrote in
> > Before there, InitWalRecovery changes the state to
> > DB_IN_ARCHIVE_RECO
Hi,
On 2022-03-23 17:27:50 +0900, Kyotaro Horiguchi wrote:
> At Mon, 21 Mar 2022 14:30:17 -0700, Andres Freund wrote
> in
> > > Right now we reset stats for replicas, even if we start from a shutdown
> > > checkpoint. That seems pretty unnecessary with this patch:
> > > - 0021-pgstat-wip-only-r
At Mon, 21 Mar 2022 14:30:17 -0700, Andres Freund wrote in
> > Right now we reset stats for replicas, even if we start from a shutdown
> > checkpoint. That seems pretty unnecessary with this patch:
> > - 0021-pgstat-wip-only-reset-pgstat-data-after-crash-re.patch
>
> Might raise this in another
At Tue, 22 Mar 2022 11:56:40 +0900 (JST), Kyotaro Horiguchi
wrote in
> Docs.. Yeah I'll try it.
This is the first cut, based on the earlier patchset.
monitoring.sgml:
>When using the statistics to monitor collected data, it is important
I failed to read this clearly. I modified the part
At Mon, 21 Mar 2022 14:30:17 -0700, Andres Freund wrote in
> Hi,
>
> Attached is v67 of the patch. Changes:
Thanks for the lot of work on this.
> > This is also painful to maintain. Mostly kept separate from 0007 for easier
> > reviewing:
> > - 0009-pgstat-reorder-file-pgstat.c-pgstat.h-conte
