Re: unnecessary creation of FSM files during bootstrap mode

2019-01-11 Thread Amit Kapila
On Fri, Jan 11, 2019 at 8:01 PM Tom Lane wrote: > > Amit Kapila writes: > > On Fri, Jan 11, 2019 at 5:00 AM Tom Lane wrote: > >> It's also possible that you just aren't exercising the cases where > >> trouble occurs. In particular, noting this bit in InsertOneValue(): > >> OidOutputFunctionCall

Re: unnecessary creation of FSM files during bootstrap mode

2019-01-11 Thread Tom Lane
Amit Kapila writes: > On Fri, Jan 11, 2019 at 5:00 AM Tom Lane wrote: >> It's also possible that you just aren't exercising the cases where >> trouble occurs. In particular, noting this bit in InsertOneValue(): >> OidOutputFunctionCall(typoutput, values[i]; > I have tried initdb with --debu

Re: unnecessary creation of FSM files during bootstrap mode

2019-01-11 Thread Amit Kapila
On Fri, Jan 11, 2019 at 5:00 AM Tom Lane wrote: > It's also possible that you just aren't exercising the cases where > trouble occurs. In particular, noting this bit in InsertOneValue(): > > /* > * We use ereport not elog here so that parameters aren't evaluated unless > * the messa

Re: unnecessary creation of FSM files during bootstrap mode

2019-01-10 Thread Tom Lane
John Naylor writes: > Thought I'd ping... Sorry, I'd not been paying attention to this thread. > On Sat, Dec 15, 2018 at 12:02 AM Amit Kapila wrote: >> As pointed out by John Naylor [1], it seems during bootstrap mode, we >> are always creating FSM files which are not required. In commit's >>

Re: unnecessary creation of FSM files during bootstrap mode

2019-01-10 Thread John Naylor
Thought I'd ping... (sorry for the top post) On Sat, Dec 15, 2018 at 12:02 AM Amit Kapila wrote: > > As pointed out by John Naylor [1], it seems during bootstrap mode, we > are always creating FSM files which are not required. In commit's > b9d01fe288 and 3908473c80, we have added some code wher