Re: Recovery of .partial WAL segments

2024-10-18 Thread Matthias van de Meent
On Fri, 5 Apr 2024 at 11:45, Stefan Fercot wrote: > > Dear hackers, > > Generating a ".partial" WAL segment is pretty common nowadays (using > pg_receivewal or during standby promotion). > However, we currently don't do anything with it unless the user manually > removes that ".partial" extensio

Re: Recovery of .partial WAL segments

2024-10-18 Thread Stefan Fercot
Hi, On Fri, Oct 18, 2024 at 11:07 AM Stepan Neretin wrote: > Hi there! It looks good to me! > Thanks! But I have a question. How is the partialxlogfname freed in case of an > error? I'm not sure I understand your question. What kind of error would you expect exactly? I mostly added a pfree t

Re: Recovery of .partial WAL segments

2024-10-18 Thread Stepan Neretin
Hi there! It looks good to me! But I have a question. How is the partialxlogfname freed in case of an error? Best regards, Stepan Neretin.

Re: Recovery of .partial WAL segments

2024-08-09 Thread Stefan Fercot
Hi, On Fri, Aug 9, 2024 at 4:29 PM Dmitry Dolgov <9erthali...@gmail.com> wrote: > Seems like the retry loop from 019_replslot_limit might help. > Thanks for the tip. Attached v2 adds the retry loop in the test which would hopefully fix the cfbot. Kind Regards, Stefan From 203747394503b479338980

Re: Recovery of .partial WAL segments

2024-08-09 Thread Dmitry Dolgov
> On Fri, Aug 02, 2024 at 08:47:02AM GMT, Stefan Fercot wrote: > > Not sure why CFbot CI fails on macOS/Windows while it works with the Github > CI on my fork ( > https://cirrus-ci.com/github/pgstef/postgres/partial-walseg-recovery). I guess it's because the test has to wait a bit after the node h

Re: Recovery of .partial WAL segments

2024-08-01 Thread Stefan Fercot
Hi, I've added a CF entry for this patch: https://commitfest.postgresql.org/49/5148/ Not sure why CFbot CI fails on macOS/Windows while it works with the Github CI on my fork ( https://cirrus-ci.com/github/pgstef/postgres/partial-walseg-recovery). Many thanks in advance for your feedback and tho

Recovery of .partial WAL segments

2024-04-05 Thread Stefan Fercot
Dear hackers, Generating a ".partial" WAL segment is pretty common nowadays (using pg_receivewal or during standby promotion). However, we currently don't do anything with it unless the user manually removes that ".partial" extension. The 028_pitr_timelines tests are highlighting that fact: wit