Re: Regression test failure in regression test temp.sql

2019-08-13 Thread Michael Paquier
On Tue, Aug 13, 2019 at 12:15:26PM +0900, Michael Paquier wrote: > Indeed. Good catch! Perhaps you would like to fix it? There are two > queries in need of an ORDER BY, and the second query even uses two > semicolons (spoiler warning: that's a nit). And fixed. The test case was new as of v12.

Re: Regression test failure in regression test temp.sql

2019-08-12 Thread Michael Paquier
On Tue, Aug 13, 2019 at 02:51:03PM +1200, Thomas Munro wrote: > Here's another one that seems to fit that pattern. > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2019-08-11%2007%3A33%3A39 Indeed. Good catch! Perhaps you would like to fix it? There are two queries in need of

Re: Regression test failure in regression test temp.sql

2019-08-12 Thread Thomas Munro
On Tue, Aug 13, 2019 at 1:58 PM Michael Paquier wrote: > On Sun, Aug 11, 2019 at 03:59:06PM -0400, Tom Lane wrote: > > I hacked temp.sql to print a couple different plans (doing it that way, > > rather than manually, just to ensure that I was getting plans matching > > what would actually happen r

Re: Regression test failure in regression test temp.sql

2019-08-12 Thread Michael Paquier
On Sun, Aug 11, 2019 at 03:59:06PM -0400, Tom Lane wrote: > I hacked temp.sql to print a couple different plans (doing it that way, > rather than manually, just to ensure that I was getting plans matching > what would actually happen right there). And what I see, as attached, > is that IOS and pla

Re: Regression test failure in regression test temp.sql

2019-08-11 Thread Tom Lane
Michael Paquier writes: > On Wed, Aug 07, 2019 at 10:17:25AM -0400, Tom Lane wrote: >> Not objecting to the patch, exactly, just feeling like there's >> more here than meets the eye. Not quite sure if it's worth >> investigating closer, or what we'd even need to do to do so. > Yes, something's w

Re: Regression test failure in regression test temp.sql

2019-08-08 Thread Michael Paquier
On Wed, Aug 07, 2019 at 10:17:25AM -0400, Tom Lane wrote: > Not objecting to the patch, exactly, just feeling like there's > more here than meets the eye. Not quite sure if it's worth > investigating closer, or what we'd even need to do to do so. Yes, something's weird here. I'd think that the i

Re: Regression test failure in regression test temp.sql

2019-08-07 Thread Tom Lane
Michael Paquier writes: > While browsing the buildfarm failures, I have found this problem on > anole for the test temp: > ... > This could be solved just with an ORDER BY as per the attached. Any > objections? There's no reason to expect stability of row order in pg_class, so in principle this

Regression test failure in regression test temp.sql

2019-08-07 Thread Michael Paquier
Hi all, While browsing the buildfarm failures, I have found this problem on anole for the test temp: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=anole&dt=2019-08-07%2006%3A39%3A35 select relname from pg_class where relname like 'temp_parted_oncommit_test%'; relname ---