Re: Removing GlobalVisTestNonRemovableHorizon

2024-04-17 Thread Andres Freund
On 2024-04-16 07:32:55 +0900, Michael Paquier wrote: > On Mon, Apr 15, 2024 at 11:57:20AM -0700, Andres Freund wrote: > > GlobalVisTestNonRemovableHorizon()/GlobalVisTestNonRemovableFullHorizon() > > only > > existed for snapshot_too_old - but that was removed in f691f5b80a8. I'm > > inclined to

Re: Removing GlobalVisTestNonRemovableHorizon

2024-04-17 Thread Andres Freund
Hi, On 2024-04-15 15:13:51 -0400, Robert Haas wrote: > It would of course have been nice to have done this sooner, but I don't > think waiting for next release cycle will make anything better. I don't really know how it could have been discovered sooner. We don't have any infrastructure for

Re: Removing GlobalVisTestNonRemovableHorizon

2024-04-15 Thread Michael Paquier
On Mon, Apr 15, 2024 at 11:57:20AM -0700, Andres Freund wrote: > GlobalVisTestNonRemovableHorizon()/GlobalVisTestNonRemovableFullHorizon() only > existed for snapshot_too_old - but that was removed in f691f5b80a8. I'm > inclined to think we should remove those functions for 17. No new code

Re: Removing GlobalVisTestNonRemovableHorizon

2024-04-15 Thread Robert Haas
On Mon, Apr 15, 2024 at 2:57 PM Andres Freund wrote: > GlobalVisTestNonRemovableHorizon()/GlobalVisTestNonRemovableFullHorizon() only > existed for snapshot_too_old - but that was removed in f691f5b80a8. I'm > inclined to think we should remove those functions for 17. No new code should > use

Removing GlobalVisTestNonRemovableHorizon

2024-04-15 Thread Andres Freund
Hi, GlobalVisTestNonRemovableHorizon()/GlobalVisTestNonRemovableFullHorizon() only existed for snapshot_too_old - but that was removed in f691f5b80a8. I'm inclined to think we should remove those functions for 17. No new code should use them. Greetings, Andres Freund