Re: Should the archiver process always make sure that the timeline history files exist in the archive?

2024-02-01 Thread vignesh C
On Thu, 11 Jan 2024 at 20:38, vignesh C wrote: > > On Tue, 29 Aug 2023 at 06:29, Jimmy Yih wrote: > > > > Thanks for the insightful response! I have attached an updated patch > > that moves the proposed logic to the end of StartupXLOG where it seems > > more correct to do this. It also helps

Re: Should the archiver process always make sure that the timeline history files exist in the archive?

2024-01-11 Thread vignesh C
On Tue, 29 Aug 2023 at 06:29, Jimmy Yih wrote: > > Thanks for the insightful response! I have attached an updated patch > that moves the proposed logic to the end of StartupXLOG where it seems > more correct to do this. It also helps with backporting (if it's > needed) since the archiver process

Re: Should the archiver process always make sure that the timeline history files exist in the archive?

2024-01-05 Thread Robert Haas
On Mon, Aug 28, 2023 at 8:59 PM Jimmy Yih wrote: > Thanks for the insightful response! I have attached an updated patch > that moves the proposed logic to the end of StartupXLOG where it seems > more correct to do this. It also helps with backporting (if it's > needed) since the archiver process

Re: Should the archiver process always make sure that the timeline history files exist in the archive?

2023-08-28 Thread Jimmy Yih
Thanks for the insightful response! I have attached an updated patch that moves the proposed logic to the end of StartupXLOG where it seems more correct to do this. It also helps with backporting (if it's needed) since the archiver process only has access to shared memory starting from Postgres

Re: Should the archiver process always make sure that the timeline history files exist in the archive?

2023-08-24 Thread Kyotaro Horiguchi
At Wed, 16 Aug 2023 07:33:29 +, Jimmy Yih wrote in > Hello pgsql-hackers, > > After doing some more debugging on the matter, I believe this issue might be a > minor regression from commit 5332b8cec541. Prior to that commit, the archiver > process when first started on a previously promoted

Re: Should the archiver process always make sure that the timeline history files exist in the archive?

2023-08-16 Thread Jimmy Yih
Hello pgsql-hackers, After doing some more debugging on the matter, I believe this issue might be a minor regression from commit 5332b8cec541. Prior to that commit, the archiver process when first started on a previously promoted primary would have all the timeline history files marked as ready

Should the archiver process always make sure that the timeline history files exist in the archive?

2023-08-09 Thread Jimmy Yih
Hello pgsql-hackers, While testing out some WAL archiving and PITR scenarios, it was observed that enabling WAL archiving for the first time on a primary that was on a timeline higher than 1 would not initially archive the timeline history file for the timeline it was currently on. While this