Re: Should we represent temp files as unsigned long int instead of signed long int type?

2023-10-25 Thread Tom Lane
Michael Paquier writes: > In the mood of removing long because it may be 4 bytes or 8 bytes > depending on the environment, I'd suggest to change it to either int64 > or uint64. Not that it matters much for this specific case, but that > makes the code more portable. Then you're going to need a

Re: Should we represent temp files as unsigned long int instead of signed long int type?

2023-10-25 Thread Michael Paquier
On Wed, Oct 25, 2023 at 03:07:39PM -0400, Tom Lane wrote: > AFAIK, nothing particularly awful will happen if that counter wraps > around. Perhaps if you gamed the system really hard, you could cause > a collision with a still-extant temp file from the previous cycle, > but I seriously doubt that

Re: Should we represent temp files as unsigned long int instead of signed long int type?

2023-10-25 Thread Robert Haas
On Wed, Oct 25, 2023 at 1:28 PM Ashutosh Sharma wrote: > At present, we represent temp files as a signed long int number. And > depending on the system architecture (32 bit or 64 bit), the range of > signed long int varies, for example on a 32-bit system it will range > from -2,147,483,648 to

Re: Should we represent temp files as unsigned long int instead of signed long int type?

2023-10-25 Thread Tom Lane
Ashutosh Sharma writes: > At present, we represent temp files as a signed long int number. And > depending on the system architecture (32 bit or 64 bit), the range of > signed long int varies, for example on a 32-bit system it will range > from -2,147,483,648 to 2,147,483,647. AFAIU, this will

Should we represent temp files as unsigned long int instead of signed long int type?

2023-10-25 Thread Ashutosh Sharma
Hi All, At present, we represent temp files as a signed long int number. And depending on the system architecture (32 bit or 64 bit), the range of signed long int varies, for example on a 32-bit system it will range from -2,147,483,648 to 2,147,483,647. AFAIU, this will not allow a session to