Re: Size and size_t in dsa API

2018-09-21 Thread Thomas Munro
On Thu, Sep 20, 2018 at 10:13 PM Ideriha, Takeshi wrote: > >> As a non-expert developer's opinion, I think mixing of Size and size_t > >> makes difficult > >to understand source code. > > > >Agreed. Let's change them all to size_t and back-patch that to keep future > >back-patching easy. Patch

RE: Size and size_t in dsa API

2018-09-20 Thread Ideriha, Takeshi
>> As a non-expert developer's opinion, I think mixing of Size and size_t makes >> difficult >to understand source code. > >Agreed. Let's change them all to size_t and back-patch that to keep future >back-patching easy. Patch attached. Thank you for the quick action. I'm happy now. I confirmed

Re: Size and size_t in dsa API

2018-09-20 Thread Thomas Munro
On Thu, Sep 20, 2018 at 6:28 PM Ideriha, Takeshi wrote: > As a non-expert developer's opinion, I think mixing of Size and size_t makes > difficult to understand source code. Agreed. Let's change them all to size_t and back-patch that to keep future back-patching easy. Patch attached. -- Thom

Size and size_t in dsa API

2018-09-19 Thread Ideriha, Takeshi
Hi, I'm trying to use DSA API and confused a little bit about $subject. Some type of return value or arguments are defined as size_t but others are as Size. Example: - dsa_area *dsa_create_in_place(void *place, size_t size, int tranche_id, dsm_segment *segment) - Size dsa_