Re: Skip recovery/standby signal files in pg_basebackup

2019-09-30 Thread Ashutosh Sharma
Hi David, On Sat, Sep 28, 2019 at 12:23 AM David Steele wrote: > > Hackers, > > Restoring these files could cause surprising behaviors so it seems best > to let the restore process create them when needed. > Could you please let us know what is the surprising behaviour you are talking about here

Re: Skip recovery/standby signal files in pg_basebackup

2019-09-30 Thread Michael Paquier
On Fri, Sep 27, 2019 at 02:52:54PM -0400, David Steele wrote: > Restoring these files could cause surprising behaviors so it seems best > to let the restore process create them when needed. > > Patch is attached. When taking a base backup from a standby, we have always copied recovery.conf if pre

Re: Skip recovery/standby signal files in pg_basebackup

2019-09-30 Thread Masahiko Sawada
On Sat, Sep 28, 2019 at 3:53 AM David Steele wrote: > > Hackers, > > Restoring these files could cause surprising behaviors so it seems best > to let the restore process create them when needed. It's not a normal situation where a running postgres has either recovery.signal or standby.signal but

Skip recovery/standby signal files in pg_basebackup

2019-09-27 Thread David Steele
Hackers, Restoring these files could cause surprising behaviors so it seems best to let the restore process create them when needed. Patch is attached. -- -David da...@pgmasters.net From 1b3d95607afeb4f1fa98c3ea006f310ab68252f7 Mon Sep 17 00:00:00 2001 From: David Steele Date: Fri, 27 Sep 2019