Re: Small omission in type_sanity.sql

2023-03-09 Thread Alvaro Herrera
On 2023-Jan-27, Andres Freund wrote: > On 2023-01-27 20:39:04 -0500, Tom Lane wrote: > > Andres Freund writes: > > > Tom, is there a reason we run the various sanity tests early-ish in the > > > schedule? It does seem to reduce their effectiveness a bit... > > > > Originally, those tests were ma

Re: Small omission in type_sanity.sql

2023-01-27 Thread Andres Freund
Hi, On 2023-01-27 20:39:04 -0500, Tom Lane wrote: > Andres Freund writes: > > Tom, is there a reason we run the various sanity tests early-ish in the > > schedule? It does seem to reduce their effectiveness a bit... > > Originally, those tests were mainly needed to sanity-check the > hand-mainta

Re: Small omission in type_sanity.sql

2023-01-27 Thread Tom Lane
Andres Freund writes: > Tom, is there a reason we run the various sanity tests early-ish in the > schedule? It does seem to reduce their effectiveness a bit... Originally, those tests were mainly needed to sanity-check the hand-maintained initial catalog data, so it made sense to run them early.

Re: Small omission in type_sanity.sql

2023-01-27 Thread Andres Freund
Hi, On 2023-01-18 14:51:32 -0500, Melanie Plageman wrote: > I only changed these few lines in type_sanity to be more correct; I > didn't change anything else in regress to actually exercise them (e.g. > ensuring a partitioned table is around when running type_sanity). It > might be worth moving ty

Small omission in type_sanity.sql

2023-01-18 Thread Melanie Plageman
Hi, I was playing around with splitting up the tablespace test in regress so that I could use the tablespaces it creates in another test and happened to notice that the pg_class validity checks in type_sanity.sql are incomplete. It seems that 8b08f7d4820fd did not update the pg_class tests in typ