Re: Suggestions for improving \conninfo output in v18

On 2025/06/13 22:50, Nathan Bossart wrote: On Fri, Jun 13, 2025 at 06:52:26PM +0900, Fujii Masao wrote: I've added the RMT to CC. What do you think about including the 0001 patch in v18? Would you be okay with that? --- The 0001 patch changes \conninfo to report the full

Re: Suggestions for improving \conninfo output in v18

On Fri, Jun 13, 2025 at 06:52:26PM +0900, Fujii Masao wrote: > I've added the RMT to CC. What do you think about including the 0001 patch in > v18? > Would you be okay with that? > > --- > The 0001 patch changes \conninfo to report the full protocol version (e.g., > 3.2) > in

Re: Suggestions for improving \conninfo output in v18

On 2025/06/13 13:32, Tom Lane wrote: "David G. Johnston" writes: On Thu, Jun 12, 2025 at 8:05 PM Fujii Masao wrote: Therefore I see this as fixing an oversight in commit bba2fbc6238, so I'd like to commit the 0001 patch as well in v18. Thought? You should get the concurrence of the RMT.

Re: Suggestions for improving \conninfo output in v18

"David G. Johnston" writes: > On Thu, Jun 12, 2025 at 8:05 PM Fujii Masao > wrote: >> Therefore I see this as fixing an oversight in commit bba2fbc6238, so I'd >> like to commit the 0001 patch as well in v18. Thought? > You should get the concurrence of the RMT. > ... > Also, I was under the imp

Re: Suggestions for improving \conninfo output in v18

On Thu, Jun 12, 2025 at 8:05 PM Fujii Masao wrote: > On 2025/06/04 20:18, Fujii Masao wrote: > > > I've also re-attached the 0001 patch that makes \conninfo report the full > > protocol version, it's the same as the one I posted earlier in the > thread. > > The 0001 patch changes \conninfo to rep

Re: Suggestions for improving \conninfo output in v18

On 2025/06/04 20:18, Fujii Masao wrote: On 2025/06/03 20:22, Robert Treat wrote: +1 on the idea to put it there; if someone gets confused about the behavior, that seems like the place they'd go to look it up. Though I would wordsmith the patch a little: +  Note that the Client User

Re: Suggestions for improving \conninfo output in v18

On 2025/06/03 20:22, Robert Treat wrote: +1 on the idea to put it there; if someone gets confused about the behavior, that seems like the place they'd go to look it up. Though I would wordsmith the patch a little: + Note that the Client User field shows the user at the time +

Re: Suggestions for improving \conninfo output in v18

On Tue, Jun 3, 2025 at 4:28 AM Fujii Masao wrote: > On 2025/06/02 21:53, David G. Johnston wrote: > > On Sunday, June 1, 2025, Fujii Masao > > wrote: > > > > On 2025/06/02 14:24, David G. Johnston wrote: > > > > On Sunday, June 1, 2025, Fujii Masao

Re: Suggestions for improving \conninfo output in v18

On 2025/06/02 21:53, David G. Johnston wrote: On Sunday, June 1, 2025, Fujii Masao mailto:masao.fu...@oss.nttdata.com>> wrote: On 2025/06/02 14:24, David G. Johnston wrote: On Sunday, June 1, 2025, Fujii Masao mailto:masao.fu...@oss.nttdata.com>

Re: Suggestions for improving \conninfo output in v18

On Sunday, June 1, 2025, Fujii Masao wrote: > > On 2025/06/02 14:24, David G. Johnston wrote: > >> On Sunday, June 1, 2025, Fujii Masao > > wrote: >> > Also, I noticed that the "Client User" column reflects the user at >> the time of connection, while th

Re: Suggestions for improving \conninfo output in v18

On 2025/06/02 14:24, David G. Johnston wrote: On Sunday, June 1, 2025, Fujii Masao mailto:masao.fu...@oss.nttdata.com>> wrote: In v18, the "Protocol Version" column shown by \conninfo reports only the major version (e.g., 3). Wouldn't it be more helpful to show the full version (e.

Re: Suggestions for improving \conninfo output in v18

On Sunday, June 1, 2025, Fujii Masao wrote: > > In v18, the "Protocol Version" column shown by \conninfo reports only > the major version (e.g., 3). Wouldn't it be more helpful to show the full > version (e.g., 3.2) using PQfullProtocolVersion()? Since support for > protocol version 3.2 was introd

Suggestions for improving \conninfo output in v18

Hi, In v18, the "Protocol Version" column shown by \conninfo reports only the major version (e.g., 3). Wouldn't it be more helpful to show the full version (e.g., 3.2) using PQfullProtocolVersion()? Since support for protocol version 3.2 was introduced in v18, users may want to know exactly which